Open
Conversation
Member
Author
|
FYI @kevinjqliu |
Contributor
|
Is there any way to test this? The verify-release-candidate workflow doesn't seem tohave run on this PR |
alamb
approved these changes
Apr 10, 2026
| - name: Set RUSTFLAGS for Windows GNU linker | ||
| if: matrix.os == 'windows' | ||
| shell: bash | ||
| run: echo "RUSTFLAGS=-C link-arg=-Wl,--exclude-libs=ALL" >> "$GITHUB_ENV" |
Contributor
There was a problem hiding this comment.
the title of this PR says it is setting the linker to msvc but this seems to actually to disable automatic symbol export
https://linux.die.net/man/1/ld
--exclude-libs lib,lib,...
Specifies a list of archive libraries from which symbols should not be automatically exported. The library names may be delimited by commas or colons. Specifying "--exclude-libs ALL" excludes symbols in all archive libraries from automatic export. This option is available only for the i386 PE targeted port of the linker and for ELF targeted ports. For i386 PE , symbols explicitly listed in a .def file are still exported, regardless of this option. For ELF targeted ports, symbols affected by this option will be treated as hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, but the verification script was failing on windows.
Rationale for this change
Linker was failing on 53.0.0 even though our CI builds were fine. This appears to be due to the debug build and number of linked objects in 53.0.0. This switches to msvc linker which does not have the same issue.
What changes are included in this PR?
Sets linker flag in verification script.
Are there any user-facing changes?
No
Testing
Demonstration that it now works:
https://github.com/apache/datafusion-python/actions/runs/24263082673