fix: output_bytes metric in hash aggregation#23777
Open
ariel-miculas wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23777 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01%
==========================================
Files 1089 1089
Lines 368748 368928 +180
Branches 368748 368928 +180
==========================================
+ Hits 297633 297771 +138
- Misses 53372 53390 +18
- Partials 17743 17767 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @ariel-miculas! I was taking a look at the failing CI checks to see if I could help unblock this. Fixing that one word should turn the CI green. Hope this helps, and great work on the hash aggregation metrics! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Summing together the produced sliced RecordBatches in hash aggregation leads to inflated output_bytes metric
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
If the metrics are user-facing, then yes.