Skip to content

feat: Add From<Option<T>> trait for Precision enum #22792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kosiew merged 5 commits into from
Jun 10, 2026
+6 −0
Merged

feat: Add From<Option<T>> trait for Precision enum #22792

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0eafb15
feat: Add From<Option<T>> trait for Precision enum
devanbenz Jun 6, 2026
03fe9a3
Merge branch 'main' into db/opt-to-precision
devanbenz Jun 6, 2026
23aa689
chore: Merge branch 'main' into db/opt-to-precision
devanbenz Jun 8, 2026
15da486
feat: Use map_or
devanbenz Jun 9, 2026
b606716
Merge branch 'main' into db/opt-to-precision
devanbenz Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions datafusion/common/src/stats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,12 @@ impl Precision<ScalarValue> {
}
}

impl<T: Debug + Clone + PartialEq + Eq + PartialOrd> From<Option<T>> for Precision<T> {
fn from(option: Option<T>) -> Self {

@kosiew kosiew Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small readability suggestion: this Option match can be collapsed without changing behavior. This keeps the mapping from Some to Exact and None to Absent pretty direct:

option.map_or(Precision::Absent, Precision::Exact)

@devanbenz devanbenz Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, made the changes.

option.map_or(Precision::Absent, Precision::Exact)
}
}

impl<T: Debug + Clone + PartialEq + Eq + PartialOrd> Debug for Precision<T> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Expand Down
Loading