perf: Optimize NULL handling in array_slice#21482
Merged
mbutrovich merged 1 commit intoapache:mainfrom Apr 10, 2026
Merged
Conversation
metegenez
approved these changes
Apr 10, 2026
Contributor
metegenez
left a comment
There was a problem hiding this comment.
LGTM. Just 1 concern: Is there a test with nulls at overlapping positions across multiple inputs (array null at row 0, from null at rows 0–1, to null at row 2)? If not in slt already, worth adding one to pin the union semantics.
mbutrovich
approved these changes
Apr 10, 2026
Contributor
mbutrovich
left a comment
There was a problem hiding this comment.
Makes a lot a of sense to me, @neilconway! Thanks for the performance improvements!
| } | ||
|
|
||
| /// Combine null bitmaps from all slice inputs into a single mask. | ||
| fn combine_input_nulls( |
Contributor
There was a problem hiding this comment.
This one in particular got me to fire off this PR: apache/arrow-rs#9692.
We can clean up this implementation if that lands in Arrow-rs.
neilconway
added a commit
to neilconway/datafusion
that referenced
this pull request
Apr 10, 2026
Pin the NullBuffer::union semantics introduced in apache#21482 by testing rows where multiple inputs (array, from, to, stride) are simultaneously null.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
) Per reviewer comment in #21482, this adds a test case for `array_slice` for various situations in which multiple inputs (array, from, to, stride) are simultaneously null.
This was referenced Apr 13, 2026
alamb
added a commit
to apache/arrow-rs
that referenced
this pull request
Apr 14, 2026
…on_many` (#9692) ## Which issue does this PR close? - Closes #8809. ## Rationale for this change Several DataFusion PRs ([#21464](apache/datafusion#21464), [#21468](apache/datafusion#21468), [#21471](apache/datafusion#21471), [#21475](apache/datafusion#21475), [#21477](apache/datafusion#21477), [#21482](apache/datafusion#21482), [#21532](apache/datafusion#21532)) optimize NULL handling in scalar functions by replacing row-by-row null buffer construction with bulk `NullBuffer::union`. When 3+ null buffers need combining, they chain binary `union` calls, each allocating a new `BooleanBuffer`. `NullBuffer::union_many` reduces this to 1 allocation (clone + in-place ANDs). For example, from [#21482](apache/datafusion#21482): Before: ```rust [array.nulls(), from_array.nulls(), to_array.nulls(), stride.and_then(|s| s.nulls())] .into_iter() .fold(None, |acc, nulls| NullBuffer::union(acc.as_ref(), nulls)) ``` After: ```rust NullBuffer::union_many([ array.nulls(), from_array.nulls(), to_array.nulls(), stride.and_then(|s| s.nulls()), ]) ``` Per @alamb's [suggestion](#9692 (comment)), this PR also implements the general-purpose mutable bitwise operations on `BooleanArray` from #8809, following the `PrimitiveArray::unary` / `unary_mut` pattern. This builds on the `BitAndAssign`/`BitOrAssign`/`BitXorAssign` operators added to `BooleanBuffer` in #9567. ## What changes are included in this PR? **`NullBuffer::union_many(impl IntoIterator<Item = Option<&NullBuffer>>)`**: combines multiple null buffers in a single allocation (clone + in-place `&=`). Used by DataFusion for bulk null handling. **`BooleanArray` bitwise operations** (6 new public methods): Unary (`op: FnMut(u64) -> u64`): - `bitwise_unary(&self, op)` — always allocates a new array - `bitwise_unary_mut(self, op) -> Result<Self, Self>` — in-place if uniquely owned, `Err(self)` if shared - `bitwise_unary_mut_or_clone(self, op)` — in-place if uniquely owned, allocates if shared Binary (`op: FnMut(u64, u64) -> u64`): - `bitwise_bin_op(&self, rhs, op)` — always allocates, unions null buffers - `bitwise_bin_op_mut(self, rhs, op) -> Result<Self, Self>` — in-place if uniquely owned, `Err(self)` if shared, unions null buffers - `bitwise_bin_op_mut_or_clone(self, rhs, op)` — in-place if uniquely owned, allocates if shared, unions null buffers Note: #8809 proposed the binary variants take a raw buffer and `right_offset_in_bits`. This PR takes `&BooleanArray` instead, which encapsulates both and matches existing patterns like `BooleanArray::from_binary`. ## Are these changes tested? Yes. 23 tests for the `BooleanArray` bitwise methods and 6 tests for `union_many`, covering: - Basic correctness (AND, OR, NOT) - Null handling (both nullable, one nullable, no nulls, null union) - Buffer ownership (uniquely owned → in-place, shared → `Err` / fallback) - Edge cases (empty arrays, sliced arrays with non-zero offset, misaligned left/right offsets) ## Are there any user-facing changes? Six new public methods on `BooleanArray` and one new public method on `NullBuffer`. --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
## Which issue does this PR close? - Closes apache#21481. ## Rationale for this change `array_slice` does a per-row NULL checking (in four different arrays!). It would be faster to take the union of the four input NULL buffers via `NullBuffer::union`. Benchmarks (Arm64): ``` - List(Int64), array args: 60.98ms -> 58.35ms (-4.3%) - List(Int64), array args, no stride: 28.19ms -> 25.92ms (-8.0%) - List(Int64), scalar args, no stride: 57.07ms -> 55.56ms (-2.6%) - List(Int64), scalar args, stride=-2: 99.44ms -> 96.05ms (-3.4%) - List(Int64), scalar args, stride=-1: 155.23ms -> 155.30ms (+0.0%) - List(Int64), scalar args, stride=1: 58.50ms -> 55.91ms (-4.4%) - List(Int64), scalar args, stride=2: 151.45ms -> 146.83ms (-3.1%) - ListView(Int64), array args: 56.19ms -> 52.86ms (-5.9%) - ListView(Int64), array args, no stride: 28.53ms -> 24.35ms (-14.7%) - ListView(Int64), scalar args, no stride: 58.65ms -> 58.34ms (-0.5%) - ListView(Int64), scalar args, stride=-2: 93.85ms -> 91.59ms (-2.4%) - ListView(Int64), scalar args, stride=-1: 149.68ms -> 149.06ms (-0.4%) - ListView(Int64), scalar args, stride=1: 59.53ms -> 58.90ms (-1.1%) - ListView(Int64), scalar args, stride=2: 143.07ms -> 139.55ms (-2.5%) ``` ## What changes are included in this PR? ## Are these changes tested? Yes. ## Are there any user-facing changes? No.
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
…che#21540) Per reviewer comment in apache#21482, this adds a test case for `array_slice` for various situations in which multiple inputs (array, from, to, stride) are simultaneously null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_slice#21481.Rationale for this change
array_slicedoes a per-row NULL checking (in four different arrays!). It would be faster to take the union of the four input NULL buffers viaNullBuffer::union.Benchmarks (Arm64):
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.