This repository was archived by the owner on Jan 20, 2021. It is now read-only.
Fixing cks instance view#832
Merged
Merged
Conversation
Contributor
Author
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
shwstppr
reviewed
Oct 28, 2020
Contributor
There was a problem hiding this comment.
@davidjumani NICs/IP addresses for VMs are not returned in listKubernetesCluster response. Showing empty in UI,
> list kubernetesclusters id=091c6924-b697-4517-96b0-52774b755742
{
"count": 1,
"kubernetescluster": [
{
"account": "ACSUser",
"associatednetworkname": "ut3-network",
"cpunumber": "4",
"description": "ut3",
"domain": "ROOT",
"domainid": "6cef5343-18f2-11eb-b801-1e00420139c1",
"endpoint": "",
"id": "091c6924-b697-4517-96b0-52774b755742",
"kubernetesversionid": "951ef254-e002-4ffc-b3f3-57eed1409f4e",
"kubernetesversionname": "v1.15.0",
"masternodes": 1,
"memory": "4096",
"name": "ut3",
"networkid": "7a00931f-5683-4c16-a476-9cceebe816a4",
"serviceofferingid": "6b86c8ec-37c5-4cd0-b304-21a1b0c208ab",
"serviceofferingname": "CKS Instance",
"size": 1,
"state": "Starting",
"templateid": "a4ef4339-a447-44f5-baca-95762bd05178",
"virtualmachines": [
{
"account": "ACSUser",
"affinitygroup": [],
"created": "2020-10-28T10:29:04+0000",
"details": {
"dataDiskController": "osdefault",
"rootDiskController": "lsilogic"
},
"displayname": "ut3-master",
"domain": "ROOT",
"domainid": "6cef5343-18f2-11eb-b801-1e00420139c1",
"guestosid": "6d1bea79-18f2-11eb-b801-1e00420139c1",
"haenable": false,
"hypervisor": "VMware",
"id": "10aabe3c-6d88-4bbe-a7d8-601b70199d29",
"isdynamicallyscalable": false,
"name": "ut3-master",
"nic": [],
"osdisplayname": "Other Linux (64-bit)",
"ostypeid": "6d1bea79-18f2-11eb-b801-1e00420139c1",
"readonlyuidetails": "dataDiskController, rootDiskController",
"securitygroup": [],
"state": "Running",
"tags": [],
"userid": "31367125-7983-4f32-ae09-dc41cc2c8174",
"username": "user",
"zoneid": "cff0423f-76f4-40fb-bea8-95ecdfc004cc",
"zonename": "pr4131-t3091-vmware-67u3"
},
{
"account": "ACSUser",
"affinitygroup": [],
"created": "2020-10-28T10:29:37+0000",
"details": {
"dataDiskController": "osdefault",
"rootDiskController": "lsilogic"
},
"displayname": "ut3-node-1",
"domain": "ROOT",
"domainid": "6cef5343-18f2-11eb-b801-1e00420139c1",
"guestosid": "6d1bea79-18f2-11eb-b801-1e00420139c1",
"haenable": false,
"hypervisor": "VMware",
"id": "e11a4329-1cf6-4c0a-aab2-7cef325a1069",
"isdynamicallyscalable": false,
"name": "ut3-node-1",
"nic": [],
"osdisplayname": "Other Linux (64-bit)",
"ostypeid": "6d1bea79-18f2-11eb-b801-1e00420139c1",
"readonlyuidetails": "dataDiskController, rootDiskController",
"securitygroup": [],
"state": "Running",
"tags": [],
"userid": "31367125-7983-4f32-ae09-dc41cc2c8174",
"username": "user",
"zoneid": "cff0423f-76f4-40fb-bea8-95ecdfc004cc",
"zonename": "pr4131-t3091-vmware-67u3"
}
],
"zoneid": "cff0423f-76f4-40fb-bea8-95ecdfc004cc",
"zonename": "pr4131-t3091-vmware-67u3"
}
]
}
Should we remove IP address column?
Contributor
Author
|
@shwstppr Makes sense to remove it. |
1297e13 to
6cbe512
Compare
Contributor
Author
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
Contributor
Author
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
shwstppr
approved these changes
Oct 29, 2020
shwstppr
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tested with k8s cluster on VMware env
yadvr
approved these changes
Oct 29, 2020
weizhouapache
pushed a commit
that referenced
this pull request
Jan 19, 2021
* Fixing instance view * Chaning from ip to ssh port * Fixing html tags in text * Adding messages to kube actions * Removing redundant code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI fix for apache/cloudstack#4420
Also added a bunch of fixes