Skip to content

Update service offering section with new compute offering and disk offering changes#238

Merged
DaanHoogland merged 10 commits into
mainfrom
ComputeOfferingAndDiskofferingRefactor
Feb 21, 2023
Merged

Update service offering section with new compute offering and disk offering changes#238
DaanHoogland merged 10 commits into
mainfrom
ComputeOfferingAndDiskofferingRefactor

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Aug 26, 2021

This PR is to reflect the document changes with respect to the PR apache/cloudstack#5008

The changes mainly in

  1. Create compute offering
  2. Create disk offering
  3. Migrate volume
  4. Resize volume
  5. Change offering for volume
  6. Deploy VM

yadvr
yadvr reviewed Aug 27, 2021
View reviewed changes
Comment thread source/adminguide/service_offerings.rst Outdated
yadvr
yadvr reviewed Aug 27, 2021
View reviewed changes
Comment thread source/adminguide/storage.rst
yadvr
yadvr previously requested changes Aug 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

sureshanaparti
sureshanaparti reviewed Aug 31, 2021
View reviewed changes
Comment thread source/adminguide/storage.rst Outdated
sureshanaparti
sureshanaparti reviewed Aug 31, 2021
View reviewed changes
Comment thread source/adminguide/storage.rst Outdated
@apache apache deleted a comment from blueorangutan Sep 1, 2021
@apache apache deleted a comment from blueorangutan Sep 1, 2021
@apache apache deleted a comment from yadvr Sep 1, 2021
@apache apache deleted a comment from blueorangutan Sep 1, 2021
@apache apache deleted a comment from blueorangutan Sep 1, 2021
@apache apache deleted a comment from blueorangutan Sep 1, 2021
@apache apache deleted a comment from blueorangutan Sep 1, 2021
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Sep 1, 2021

@blueorangutan docbuild

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2021

@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2021

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/238. (SL-JID 136)

@yadvr yadvr added this to the 4.17 milestone Nov 15, 2021
@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Apr 26, 2022

Hi @harikrishna-patnala is this ready for review?

@nvazquez nvazquez mentioned this pull request May 11, 2022
Merged
12 tasks
@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented May 20, 2022

Ping @harikrishna-patnala

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented May 20, 2022

Hi @nvazquez, I'll update it today. thanks for reminding me.

@nvazquez nvazquez modified the milestones: 4.17, 4.18 Jun 17, 2022
@harikrishna-patnala harikrishna-patnala marked this pull request as ready for review February 13, 2023 10:54
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Feb 13, 2023

Hi @DaanHoogland can you please consider merging this PR as well, this is missed last time.
The upstream PR is already merged apache/cloudstack#5008

@harikrishna-patnala harikrishna-patnala dismissed yadvr’s stale review February 14, 2023 03:54

Addressed the review comments already

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 15, 2023

@blueorangutan docbuild

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 15, 2023

@DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 15, 2023

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/238. (QA-JID 45)

DaanHoogland
DaanHoogland reviewed Feb 15, 2023
View reviewed changes
Comment thread source/adminguide/service_offerings.rst Outdated
Comment thread source/adminguide/service_offerings.rst
Comment thread source/adminguide/service_offerings.rst Outdated

Creating a New Disk Offering
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.. image:: /_static/images/disk_offering_dailog.png
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one does show!

@apache apache deleted a comment from blueorangutan Feb 16, 2023
@apache apache deleted a comment from blueorangutan Feb 16, 2023
@apache apache deleted a comment from blueorangutan Feb 16, 2023
@apache apache deleted a comment from blueorangutan Feb 16, 2023
@harikrishna-patnala harikrishna-patnala force-pushed the ComputeOfferingAndDiskofferingRefactor branch from 2bf93fd to 3f10a59 Compare February 16, 2023 05:46
@apache apache deleted a comment from blueorangutan Feb 16, 2023
@apache apache deleted a comment from blueorangutan Feb 16, 2023
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Feb 16, 2023

@blueorangutan docbuild

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 16, 2023

@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 16, 2023

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/238. (QA-JID 51)

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Feb 16, 2023

Thanks for the review @DaanHoogland , I've addressed them.

@DaanHoogland DaanHoogland merged commit ecc72a1 into main Feb 21, 2023
@DaanHoogland DaanHoogland deleted the ComputeOfferingAndDiskofferingRefactor branch February 21, 2023 14:34
yadvr pushed a commit that referenced this pull request Sep 14, 2023
@harikrishna-patnala @kiranchavala
@DaanHoogland @shwstppr @bradh @borisstoyanov
ScaleIO volume migration documentation (#321)
820ca37 
* Update service offering section with new compute offering and disk offering changes (#238)

* Added sample ssh commands to connect to Control and Worker node (#304)

Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* Trivial editing (#305)

* volume migration docs for PowerFlex/ScaleIO storage pool

* Rename VM to Instance

* Update storage.rst package update limitation

* revert changes, as it's not needed storage.rst

---------

Co-authored-by: kiranchavala <kiranchavala@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Brad Hards <bradh@frogmouth.net>
Co-authored-by: Boris Stoyanov - a.k.a Bobby <bss.stoyanov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@yadvr yadvr yadvr left review comments

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.18

Development

Successfully merging this pull request may close these issues.

6 participants

@harikrishna-patnala @blueorangutan @nvazquez @DaanHoogland @yadvr @sureshanaparti