[wip] CLOUDSTACK-8677: use wrapper classes for gson serialisation#987
Closed
DaanHoogland wants to merge 2 commits into
Closed
[wip] CLOUDSTACK-8677: use wrapper classes for gson serialisation#987DaanHoogland wants to merge 2 commits into
DaanHoogland wants to merge 2 commits into
Conversation
Contributor
|
To add to the PR, it's not only needed for the Call-Home functionality, but we are using a very, very old version of Gson. |
Contributor
Author
|
@wido absolutly right. i'm not burning all these hours (both personal and sponsorred) just for the sake of this great marketing tool ;) |
Contributor
|
@borisroman Can we run the tests on this one? |
b708df7 to
e0941ba
Compare
e0941ba to
2ec7ba0
Compare
Member
|
@DaanHoogland can you rebase against latest master; it's huge change, advise how to test and review it |
Contributor
Author
|
I'd rather redo it then try to port forward. Testing means validating each command in an integration test. If unit testing is required; for each command and response that can go to an agent serialising and deserialising needs to be tested. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
non functional change with great risk: replace all basic type fields of json serializable objects to wrapper class type fields. It is needed for gson upgrade which is needed for phone home functionality.