Skip to content

Fix UI unit test failures#9803

Closed
vishesh92 wants to merge 1 commit into
apache:4.19from
shapeblue:fix-ui-test-failures
Closed

Fix UI unit test failures#9803
vishesh92 wants to merge 1 commit into
apache:4.19from
shapeblue:fix-ui-test-failures

Conversation

@vishesh92
Copy link
Copy Markdown
Member

Description

This PR fixes unit test failures introduced in 5ab0a52

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 force-pushed the fix-ui-test-failures branch from fbd3bb7 to 6836e2d Compare October 16, 2024 05:07
@yadvr yadvr added this to the 4.19.2.0 milestone Oct 16, 2024
@vishesh92
Copy link
Copy Markdown
Member Author

This is already fixed in #9798. Closing.

@vishesh92 vishesh92 closed this Oct 16, 2024
@vishesh92 vishesh92 deleted the fix-ui-test-failures branch October 16, 2024 05:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (017cf2c) to head (6836e2d).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9803      +/-   ##
============================================
- Coverage     15.80%   15.08%   -0.72%     
- Complexity    11199    11204       +5     
============================================
  Files          5038     5404     +366     
  Lines        443875   473417   +29542     
  Branches      52607    58380    +5773     
============================================
+ Hits          70139    71428    +1289     
- Misses       365934   394040   +28106     
- Partials       7802     7949     +147     
Flag Coverage Δ
uitests 4.30% <ø> (?)
unittests 15.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yadvr yadvr removed this from the 4.19.2.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants