[linstor] Fix instance snapshot revert and delete on linstor storage#9527
Closed
wornet-mwo wants to merge 1 commit into
Closed
[linstor] Fix instance snapshot revert and delete on linstor storage#9527wornet-mwo wants to merge 1 commit into
wornet-mwo wants to merge 1 commit into
Conversation
…ot work The snapshot strategy uses volume uuids instead of their paths. This commit fixes that. No backport to 4.18 as the file does not exist there. Signed-off-by: Michael Wodniok <michael.wodniok@wor.net>
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
code looks good, though I am not sure about the logic (cc @rp-)
@wornet-mwo , as you are making the same change in two places, can you extract it to a method, please?
Contributor
|
I have an upcoming PR that fixes migrate primary storage to Linstor, which will have this fix included. |
Contributor
Author
|
@rp- In that case i would prefer your implementation before "refactoring" here as i'm pretty sure there are more similar calls in other places. Maybe you want to link the issue in your PR. It'd be nice to link it here before closing this PR. |
Contributor
|
Here it is: #9528 |
Contributor
Author
|
Thank you, closing here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is replacing
getUuidon volume objects bygetPath. It uses the uuid , when path is not set (which may happen in some cases.Fixes: #9522
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Reproduced the issue using fresh instances on NFS storage. See linked issue for details.