CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string - #927
Merged
Conversation
Contributor
|
Code-wise it looks good, but is it possible that you add a unit test? |
Contributor
|
Results of set of tests that I run on this branch (which I rebased myself first): Result: The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this PR. And: Result: The test |
Contributor
|
@karuturi I tested the Result: |
Member
|
It might break compatibility as for some configs (global configs) people might be consuming global settings. With this change, list configuration API would return encrypted values which client or users won't know how to decrypt as they don't the encryption key. |
Member
|
I'm not sure the best to deal with it, but I would avoid putting extra security if that gets into the way of tuning the system. |
karuturi
force-pushed
the
secure-configs
branch
from
November 17, 2015 09:38
1e4ea03 to
4919210
Compare
Contributor
|
@karuturi Any updates? |
Member
|
@karuturi please rebase against latest master LGTM tag:easypr |
Contributor
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 Failed tests:
Skipped tests: Passed test suits: |
karuturi
force-pushed
the
secure-configs
branch
from
September 28, 2016 10:54
4919210 to
a6299ce
Compare
Member
|
LGTM. |
karuturi
force-pushed
the
secure-configs
branch
from
November 3, 2016 05:27
a6299ce to
563b945
Compare
karuturi
force-pushed
the
secure-configs
branch
from
February 13, 2017 09:30
563b945 to
c2c3712
Compare
Contributor
|
Code changes looks good to me. |
borisstoyanov
approved these changes
Feb 13, 2017
borisstoyanov
left a comment
Contributor
There was a problem hiding this comment.
LGTM based on code review
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-481 |
Contributor
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-816)
|
|
Smoke test test_internal_lb.py uses a value of network.loadbalancer.haproxy.stats.auth which is encrypted for haproxy checks. settings["username"], settings["password"] = Configurations.list( Looks like the test needs to be reworked to support decryption. test_04_rvpc_internallb_haproxy_stats_on_all_interfaces (tests.smoke.test_internal_lb.TestInternalLb): DEBUG: ========Sending GET Cmd : listConfigurations======= |
Member
Author
|
@serg38 Thanks for filtering the error :) My tests run has been with encryption disabled. I think trillion runs with db encryption enabled. I will check on how I can decrypt the value in tests. I will try and fix the marvin test. Any suggestions on how to run jasypt encryption and decryption in python? |
karuturi
force-pushed
the
secure-configs
branch
from
March 15, 2017 09:10
c2c3712 to
f795a44
Compare
karuturi
force-pushed
the
secure-configs
branch
from
March 31, 2017 06:06
f795a44 to
37c4b92
Compare
karuturi
force-pushed
the
secure-configs
branch
2 times, most recently
from
May 2, 2017 05:58
d7c9deb to
3fed275
Compare
…text string secure and hidden config values are first unencrypted before returning them in the api. This is not desired as they are secure configs returning encrypted strings for secure and hidden configs if encryption is enabled.
…text fixed a testcase which was using encypted value.
Member
Author
|
update the PR with testcase fix |
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 Failed tests:
Skipped tests: Passed test suits: |
|
LGTM @rhtyd @borisstoyanov @DaanHoogland Can we run B.O. for this PR? |
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-696 |
Contributor
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1057)
|
|
tag:mergeready |
Contributor
|
@karuturi , you want to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
secure and hidden config values are first unencrypted before returning
them in the api. This is not desired as they are secure configs
returning encrypted strings for secure and hidden configs if encryption
is enabled.