pre-commit: add `XML` files to the `trailing-whitespace` check by jbampton · Pull Request #9131 · apache/cloudstack

jbampton · 2024-05-28T09:55:28Z

Description

This PR adds checking for XML files for trailing whitespace.

Trailing whitespace is mostly extra space or data we don't need.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally:

pre-commit run --all-files

How did you try to break this feature and the system with this change?

codecov · 2024-05-28T10:03:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.53%. Comparing base (9f1577d) to head (bfd439a).
Report is 4 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9131     +/-   ##
===========================================
  Coverage     15.53%   15.53%             
- Complexity    11966    11969      +3     
===========================================
  Files          5492     5492             
  Lines        480929   480929             
  Branches      60325    62142   +1817     
===========================================
+ Hits          74710    74716      +6     
+ Misses       397957   397950      -7     
- Partials       8262     8263      +1

Flag	Coverage Δ
uitests	`4.17% <ø> (ø)`
unittests	`16.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jbampton · 2024-07-08T02:23:46Z

@blueorangutan package

blueorangutan · 2024-07-08T02:26:03Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-08T03:32:59Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10280

DaanHoogland

a lot of excessive whitelines and an occasional indentation remaining. I am sure I missed a lot still. Can you advise if these can be caught in sepparate rules, @jbampton?

DaanHoogland · 2024-07-08T07:03:06Z

+
+

Suggested change

DaanHoogland · 2024-07-08T07:04:22Z

  <parameter name="primary-storage-uuid-want-to-add" value="759ee4c9-a15a-297b-67c6-ac267d8abe29" />
  <parameter name="script-path" value="/Users/minc/dev/cloud-asf" />
-  
+


Suggested change

DaanHoogland · 2024-07-08T07:04:39Z

  <parameter name="image-install-path" value="template/tmpl/1/5/"/>

-   
+


Suggested change

DaanHoogland · 2024-07-08T07:06:09Z



-    
+


Suggested change

DaanHoogland · 2024-07-08T07:06:21Z

    </bean>

-    
+


Suggested change

DaanHoogland · 2024-07-08T07:55:35Z

-	
-	
+	</command>
+


Suggested change

DaanHoogland · 2024-07-08T07:56:07Z

-	
-	
+	</command>
+


Suggested change

DaanHoogland · 2024-07-08T07:56:21Z

-	
-	
+	</command>
+


Suggested change

DaanHoogland · 2024-07-08T07:56:31Z

-		
-	
+
+


Suggested change

DaanHoogland · 2024-07-08T07:56:48Z

-	
+	</command>
+
+


Suggested change

jbampton · 2024-07-08T12:51:09Z

Hey @DaanHoogland I want to focus this PR just on one check or test for trailing whitespace in the XML files.

In future we can do more clean ups since this PR already has over 3,000+ lines changed.

github-actions · 2024-07-10T09:23:37Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2024-07-11T10:55:37Z

@blueorangutan package

blueorangutan · 2024-07-11T10:56:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-11T12:29:24Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10323

JoaoJandre

LGTM, I am +1 on adding a new rule for excessive white-lines in a future PR

…e#9131)

pre-commit: add XML files to the trailing-whitespace check

fbefba8

boring-cyborg Bot added component:api component:management-server component:orchestration component:storage labels May 28, 2024

jbampton marked this pull request as draft May 28, 2024 10:36

Merge branch 'main' into pre-commit-trailing-whitespace-more-types

3d337db

jbampton marked this pull request as ready for review July 8, 2024 02:41

DaanHoogland approved these changes Jul 8, 2024

View reviewed changes

github-actions Bot added the status:has-conflicts label Jul 10, 2024

Merge branch 'main' into pre-commit-trailing-whitespace-more-types

bfd439a

github-actions Bot removed the status:has-conflicts label Jul 10, 2024

DaanHoogland requested a review from JoaoJandre July 11, 2024 10:55

JoaoJandre approved these changes Jul 11, 2024

View reviewed changes

DaanHoogland merged commit c923e67 into apache:main Jul 12, 2024

jbampton deleted the pre-commit-trailing-whitespace-more-types branch July 12, 2024 08:11

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 23, 2024

pre-commit: add XML files to the trailing-whitespace check (apach…

61fc1d8

…e#9131)

DaanHoogland added this to the 4.20.0.0 milestone Sep 6, 2024

		<parameter name="primary-storage-uuid-want-to-add" value="759ee4c9-a15a-297b-67c6-ac267d8abe29" />
		<parameter name="script-path" value="/Users/minc/dev/cloud-asf" />

		<parameter name="image-install-path" value="template/tmpl/1/5/"/>

Conversation

jbampton commented May 28, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jbampton commented Jul 8, 2024

Uh oh!

blueorangutan commented Jul 8, 2024

Uh oh!

blueorangutan commented Jul 8, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbampton commented Jul 8, 2024

Uh oh!

github-actions Bot commented Jul 10, 2024

Uh oh!

DaanHoogland commented Jul 11, 2024

Uh oh!

blueorangutan commented Jul 11, 2024

Uh oh!

blueorangutan commented Jul 11, 2024

Uh oh!

JoaoJandre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented May 28, 2024 •

edited

Loading

JoaoJandre left a comment •

edited

Loading