CLOUDSTACK-8924: Enable dynamic scaling to run test_scale_vm.py test on simulator#902
Merged
Conversation
Contributor
|
Did you execute the tests after the change? Cheers, |
|
@sanju1010 this is not the right file - the following file needs to be updated - https://github.com/apache/cloudstack/blob/94f1ebb60af320166206c213e18b97a177bc145a/setup/dev/basic.cfg |
Contributor
|
@sanju1010 Any update on this? |
|
Sanjeev N on dev@cloudstack.apache.org replies: |
Contributor
Author
|
@pvr9711 can you please review this PR? I have made changes as per the review comments and rebased it with master. |
|
LGTM, I have tested this on a private setup and is working. |
Contributor
|
@pvr9711 Can you please share the test results or explain what you did to test? |
Member
|
Simple configuration change. Code LGTM |
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Nov 4, 2015
CLOUDSTACK-8924: Enable dynamic scaling to run test_scale_vm.py test on simulatorSimulator setup uses the config file from following location: tools/marvin/marvin/config/setup.cfg Added global setting parameter "enable.dynamic.scale.vm" to above config file, so that dynamic scale vm tests can be run on simulator. * pr/902: CLOUDSTACK-8924: Made changes based on the comments from @pvr9711 Signed-off-by: Remi Bergsma <github@remi.nl>
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulator setup uses the config file from following location:
tools/marvin/marvin/config/setup.cfg
Added global setting parameter "enable.dynamic.scale.vm" to above config file, so that dynamic scale vm tests can be run on simulator.