test: fix test failures in ActionEventInterceptorTest#8938
Merged
weizhouapache merged 2 commits intoApr 19, 2024
Merged
Conversation
``` Error: Failures: Error: ActionEventInterceptorTest.testInterceptComplete:247 Error: ActionEventInterceptorTest.testInterceptException:261 Error: ActionEventInterceptorTest.testInterceptStartAsync:234 expected:<Starting VM[. Id: 0 Name: null]> but was:<Starting VM[]> ```
Member
Author
|
Not sure if it fixes the issue, let's wait for the results of github actions |
DaanHoogland
approved these changes
Apr 18, 2024
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
clgtm and fixes the issue locally for me.
Member
Author
great, thanks @DaanHoogland I kicked the build 3 times, all succeeded. https://github.com/apache/cloudstack/actions/runs/8734995428/job/23976479820?pr=8938 |
vishesh92
reviewed
Apr 19, 2024
Member
Author
|
marked as "ready for review" as it fixes the failure with build CI |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
May 3, 2024
* test: fix test failures in ActionEventInterceptorTest ``` Error: Failures: Error: ActionEventInterceptorTest.testInterceptComplete:247 Error: ActionEventInterceptorTest.testInterceptException:261 Error: ActionEventInterceptorTest.testInterceptStartAsync:234 expected:<Starting VM[. Id: 0 Name: null]> but was:<Starting VM[]> ``` * Update 8938: move CallContext.unregister as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes test failures in some PRs against main/4.20 branch
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?