Update volume's passphrase to null if diskOffering doesn't support encryption#8904
Conversation
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9236 |
ddb3351 to
fc979ae
Compare
fc979ae to
b8f60d2
Compare
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #8904 +/- ##
=============================================
- Coverage 30.98% 18.32% -12.66%
+ Complexity 34408 16841 -17567
=============================================
Files 5359 4863 -496
Lines 377017 326034 -50983
Branches 54856 45840 -9016
=============================================
- Hits 116804 59761 -57043
- Misses 244852 257783 +12931
+ Partials 15361 8490 -6871
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9250 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-9830)
|
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, it now stores NULL for volumes with no encryption
MariaDB [cloud]> select disk_offering_id,passphrase_id from volumes;
+------------------+---------------+
| disk_offering_id | passphrase_id |
+------------------+---------------+
| 9 | NULL |
| 13 | NULL |
| 1 | NULL |
| 3 | NULL |
+------------------+---------------+
4 rows in set (0.00 sec)
MariaDB [cloud]> select name,encrypt from disk_offering where id in (1,3);
+----------------+---------+
| name | encrypt |
+----------------+---------+
| Small Instance | 0 |
| Small | 0 |
+----------------+---------+
2 rows in set (0.00 sec)
Description
This PR updates the volume's passphrase to null if diskOffering doesn't support encryption
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?