Skip to content

CLOUDSTACK-8895: Verify if storage on storage pool can be attached to VM#869

Merged
asfgit merged 1 commit into
apache:masterfrom
pritisarap12:CLOUDSTACK-8895-Verify-if-storage-can-be-selected-when-attaching-uploaded-data-volume-to-VM
Feb 10, 2016
Merged

CLOUDSTACK-8895: Verify if storage on storage pool can be attached to VM#869
asfgit merged 1 commit into
apache:masterfrom
pritisarap12:CLOUDSTACK-8895-Verify-if-storage-can-be-selected-when-attaching-uploaded-data-volume-to-VM

Conversation

@pritisarap12

Copy link
Copy Markdown

Test case to verify if data volume uploaded in a storage pool(Cluster wide storage pool) is available for attachment to a Virtual Machine.and also check that after attachment the volume is in correct storage pool.

@asfbot

asfbot commented Sep 22, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #693 SUCCESS
This pull request looks good

@pritisarap12 pritisarap12 force-pushed the CLOUDSTACK-8895-Verify-if-storage-can-be-selected-when-attaching-uploaded-data-volume-to-VM branch from 48544cc to e133529 Compare September 22, 2015 07:47
@pritisarap12

Copy link
Copy Markdown
Author

Test case result:

Attach Data Disk on CWPS To VM ... === TestName: test_01_attach_datadisk_to_vm_on_zwps | Status : SUCCESS ===
ok


Ran 1 test in 188.574s

OK

@asfbot

asfbot commented Sep 22, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #694 SUCCESS
This pull request looks good

@asfbot

asfbot commented Sep 22, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #643 SUCCESS
This pull request looks good

@asfbot

asfbot commented Sep 22, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #644 ABORTED

@sebgoa

sebgoa commented Sep 30, 2015

Copy link
Copy Markdown
Member

@pritisarap12 can this be run via simulator ?

@rajap9711

Copy link
Copy Markdown

@Runseb, this cannot run on simulator.
LGTM

@remibergsma

Copy link
Copy Markdown
Contributor

@pvr9711 Where is your LGTM based on? I'd like to see some background, as otherwise we don't know what you tested / reviewed.

@sanju1010

Copy link
Copy Markdown
Contributor

I did a code walk-through and looks good.
LGTM !!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the name of this class a typo? it ends with CWPS (cluster wide primary storage?).

@sanju1010

Copy link
Copy Markdown
Contributor

It is not type Daan. First test inside TestAttachDataDisk class tests some functionality on ZWPS and this one is for CWPS.
Test Results :

Attach Data Disk To VM on ZWPS ... === TestName: test_01_attach_datadisk_to_vm_on_zwps | Status : SUCCESS === 
ok 
---------------------------------------------------------------------- 
Ran 1 tests in 122.641s 
OK

LGTM !!

@sanju1010

Copy link
Copy Markdown
Contributor

@DaanHoogland / @remibergsma can you please merge this PR?

@DaanHoogland

Copy link
Copy Markdown
Contributor

@sanju1010 it shouldn't be in the same file then, or the file should be renamed to a more generic name

@asfgit asfgit merged commit e133529 into apache:master Feb 10, 2016
asfgit pushed a commit that referenced this pull request Feb 10, 2016
…torage-can-be-selected-when-attaching-uploaded-data-volume-to-VM

CLOUDSTACK-8895: Verify if storage on storage pool can be attached to VMTest case to verify if data volume uploaded in a storage pool(Cluster wide storage pool) is available for attachment to a Virtual Machine.and also check that after attachment the volume is in correct storage pool.

* pr/869:
  CLOUDSTACK-8895: Verify if storage can be selected when attaching uploaded data volume to VM

Signed-off-by: sanjeev <sanjeev@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants