Use project version on pom dependencies#8529
Conversation
|
@blueorangutan package |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8529 +/- ##
=============================================
+ Coverage 18.28% 30.81% +12.53%
- Complexity 16826 33998 +17172
=============================================
Files 4848 5341 +493
Lines 324301 374973 +50672
Branches 45561 54546 +8985
=============================================
+ Hits 59290 115561 +56271
+ Misses 256437 244134 -12303
- Partials 8574 15278 +6704
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
looks good and if it works fine, but why these four? looking for ".*" gives a lot more occurrences of hardcoded project versions (107+ in my current 4.18 workspace) |
|
@DaanHoogland these were only on dependencies, could be fixed as well for the parent pom definition but that may be conflicting and require more testing - I can test it and propose it for 4.20 on a separate PR |
weizhouapache
left a comment
There was a problem hiding this comment.
@nvazquez
good
there is one more in
./plugins/affinity-group-processors/non-strict-host-anti-affinity/pom.xml
|
Thanks @weizhouapache, added |
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging and GH CI should be enough here @nvazquez? |
|
LGTM @shwstppr |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8360 |
This PR fixes the POM dependencies from a hardcoded value to the project.version property on dependencies
Description
This PR fixes the POM dependencies from a hardcoded value to the project.version property on dependencies
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?