ui: correctly show volume physical size#8119
Merged
Merged
Conversation
Fixes apache#8073 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 4.18 #8119 +/- ##
============================================
- Coverage 13.06% 13.06% -0.01%
+ Complexity 9109 9108 -1
============================================
Files 2720 2720
Lines 257531 257531
Branches 40150 40150
============================================
- Hits 33657 33655 -2
- Misses 219645 219648 +3
+ Partials 4229 4228 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Oct 19, 2023
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
code looks good and looks good in qa
shwstppr
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Dec 27, 2023
Fixes apache#8073 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> (cherry picked from commit f62b634) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8073
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?