Skip to content

Fix the poll for the API ReadyForShutdown even after logout#8004

Merged
yadvr merged 1 commit into
apache:mainfrom
shapeblue:fixReadyForShutdown
Sep 28, 2023
Merged

Fix the poll for the API ReadyForShutdown even after logout#8004
yadvr merged 1 commit into
apache:mainfrom
shapeblue:fixReadyForShutdown

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Sep 26, 2023

Description

This PR fixes the issue of continuous poll of ReadyForShutdown API even after logout.
This poll is causing issues after logout with unnecessary login error messages and API calls

image

Steps to reproduce the issue or test the fix

  1. Login into CloudStack
  2. Observe the Networks tab in browser development console, observe "readyForShutdown" API calls
  3. Logout from CloudStack

Observe that calling "readyForShutdown" API still continues. This PR clears that polling job.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

@harikrishna-patnala harikrishna-patnala added this to the 4.19.0.0 milestone Sep 26, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #8004 (6d2ae96) into main (b614a74) will decrease coverage by 6.79%.
Report is 6 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #8004      +/-   ##
============================================
- Coverage     28.26%   21.48%   -6.79%     
+ Complexity    29071    20857    -8214     
============================================
  Files          5100     4966     -134     
  Lines        358326   336449   -21877     
  Branches      52308    48348    -3960     
============================================
- Hits         101286    72283   -29003     
- Misses       243089   253630   +10541     
+ Partials      13951    10536    -3415
Flag Coverage Δ
simulator-marvin-tests 22.85% <ø> (-1.14%) ⬇️
uitests 4.87% <0.00%> (-0.01%) ⬇️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...he/cloudstack/api/command/ReadyForShutdownCmd.java 0.00% <ø> (ø)
ui/src/store/modules/user.js 5.06% <0.00%> (-0.03%) ⬇️
ui/src/components/page/GlobalLayout.vue 17.18% <0.00%> (-0.28%) ⬇️
ui/src/store/getters.js 13.51% <0.00%> (-0.38%) ⬇️
ui/src/store/modules/app.js 1.66% <0.00%> (-0.06%) ⬇️
ui/src/views/auth/Login.vue 0.00% <0.00%> (ø)

... and 1555 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland
DaanHoogland approved these changes Sep 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good (/me testing)

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 26, 2023

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 26, 2023

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 26, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7113

kiranchavala
kiranchavala approved these changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested it manually the ready-for-shutdown api is not called after logout

yadvr
yadvr approved these changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it but LGTM

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 27, 2023

LGTM, Tested it manually the ready-for-shutdown api is not called after logout

thanks for taking this off my hands @kiranchavala , I am running a smoke test run in the background and will merge if successful.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 27, 2023

[SF] Trillian Build Failed (tid-7727)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 27, 2023

[SF] Trillian test result (tid-7728)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51981 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8004-t7728-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3607.61 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3612.01 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 47.82 test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle Error 1.23 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 47.32 test_kubernetes_clusters.py

@yadvr yadvr merged commit 2853871 into apache:main Sep 28, 2023
@yadvr yadvr deleted the fixReadyForShutdown branch September 28, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.19.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@harikrishna-patnala @DaanHoogland @blueorangutan @yadvr @kiranchavala