Skip to content

Remove unneeded duplicate words#7850

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
jbampton:remove-duplicate-words
Sep 18, 2023
Merged

Remove unneeded duplicate words#7850
DaanHoogland merged 1 commit into
apache:mainfrom
jbampton:remove-duplicate-words

Conversation

@jbampton
Copy link
Copy Markdown
Member

@jbampton jbampton commented Aug 10, 2023

Description

This PR removes duplicate words and basically fixes grammar.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@jbampton jbampton force-pushed the remove-duplicate-words branch from d7266e1 to 88fcf2f Compare August 10, 2023 18:09
@jbampton jbampton force-pushed the remove-duplicate-words branch from 88fcf2f to 373e6a1 Compare August 10, 2023 18:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2023

Codecov Report

Merging #7850 (373e6a1) into main (9bc0dd7) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #7850   +/-   ##
=========================================
  Coverage     14.38%   14.38%           
  Complexity    10072    10072           
=========================================
  Files          2747     2747           
  Lines        258922   258922           
  Branches      40318    40318           
=========================================
  Hits          37242    37242           
  Misses       216866   216866           
  Partials       4814     4814
Files Changed Coverage Δ
...src/main/java/com/cloud/event/UsageEventUtils.java 18.86% <0.00%> (ø)
...ain/java/com/cloud/ha/HighAvailabilityManager.java 100.00% <ø> (ø)
...n/java/com/cloud/network/NetworkStateListener.java 4.76% <0.00%> (ø)
...i/src/main/java/com/cloud/storage/StorageUtil.java 1.78% <ø> (ø)
...tack/engine/orchestration/NetworkOrchestrator.java 6.06% <ø> (ø)
...ain/java/com/cloud/upgrade/dao/Upgrade218to22.java 0.12% <0.00%> (ø)
...ervisor/xenserver/resource/CitrixResourceBase.java 4.51% <0.00%> (ø)
...r/actionworkers/KubernetesClusterActionWorker.java 6.56% <0.00%> (ø)
.../com/cloud/network/resource/NetscalerResource.java 0.00% <ø> (ø)
...raNvpConfigureSharedNetworkUuidCommandWrapper.java 2.10% <0.00%> (ø)
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jbampton
Copy link
Copy Markdown
Member Author

jbampton commented Aug 11, 2023

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 11, 2023

@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 11, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6742

DaanHoogland
DaanHoogland approved these changes Aug 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knowing how good i am am at at writing, a lot of those must be mine ;)

@weizhouapache weizhouapache added this to the 4.19.0.0 milestone Aug 14, 2023
stephankruggg
stephankruggg approved these changes Sep 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephankruggg stephankruggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 18, 2023

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2023

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7037

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 18, 2023

changes only on comments, log messages and documentation strings. merging

@DaanHoogland DaanHoogland merged commit 4eb110a into apache:main Sep 18, 2023
@jbampton jbampton deleted the remove-duplicate-words branch September 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

+1 more reviewer

@stephankruggg stephankruggg stephankruggg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:api component:hyperv component:ipv6 component:kubernetes component:LDAP component:networking component:orchestration component:security-group component:storage component:XenServer

Projects

None yet

Milestone

4.19.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jbampton @blueorangutan @DaanHoogland @stephankruggg @weizhouapache