Skip to content

config: doc: add default value 10 in description for vm.network.nic.m…#777

Merged
asfgit merged 1 commit into
apache:masterfrom
resmo:fix/config-string
Sep 8, 2015
Merged

config: doc: add default value 10 in description for vm.network.nic.m…#777
asfgit merged 1 commit into
apache:masterfrom
resmo:fix/config-string

Conversation

@resmo
Copy link
Copy Markdown
Member

@resmo resmo commented Sep 4, 2015

…ax.secondary.ipaddresses

value hardcoded by commit 4925b9f

…ax.secondary.ipaddresses

value hardcoded by commit 4925b9f
@asfbot
Copy link
Copy Markdown

asfbot commented Sep 4, 2015

cloudstack-pull-rats #506 SUCCESS
This pull request looks good

@milamberspace
Copy link
Copy Markdown
Contributor

LGTM

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 4, 2015

cloudstack-pull-analysis #439 UNSTABLE
Looks like there's a problem with this pull request

@rafaelweingartner
Copy link
Copy Markdown
Member

I do not know if I can give LGTM (I am not a committer), but if I can +1 LGTM.
Errors in Jenkins are not related to this commit.

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 7, 2015

Daan Hoogland on dev@cloudstack.apache.org replies:
Rafael, and other non committing contributors,

committers are responsible for getting code merged and reverted if it
breaks things in hindsight but not the only and sometimes not even the best
people to judge code on its merits. Your opinion is very welcome to us all.

thanks for the valuable contribution of reviewing,
Daan

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 7, 2015

LGTM

@asfgit asfgit merged commit 0b956bb into apache:master Sep 8, 2015
asfgit pushed a commit that referenced this pull request Sep 8, 2015
config: doc: add default value 10 in description for vm.network.nic.max.secondary.ipaddresses

value hardcoded by commit 4925b9f

* pr/777:
  config: doc: add default value 10 in description for vm.network.nic.max.secondary.ipaddresses

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@resmo resmo deleted the fix/config-string branch October 21, 2015 12:38
yadvr pushed a commit that referenced this pull request Jan 20, 2021
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants