Skip to content

Support live migration on older version of Libvirt#771

Merged
asfgit merged 1 commit into
apache:4.5from
mike-tutkowski:4.5
Sep 2, 2015
Merged

Support live migration on older version of Libvirt#771
asfgit merged 1 commit into
apache:4.5from
mike-tutkowski:4.5

Conversation

@mike-tutkowski
Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/CLOUDSTACK-8792

A flag being passed to Libvirt assumes v1.0.0 or later.

We need to put a check in the code to pass in a different flag if the version of Libvirt is < 1.0.0.

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 1, 2015

cloudstack-pull-rats #471 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 1, 2015

cloudstack-pull-analysis #404 SUCCESS
This pull request looks good

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 2, 2015

LGTM @mike-tutkowski thanks, since the same was merged on master; will merge this on 4.5 today

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 2, 2015

Mike Tutkowski on dev@cloudstack.apache.org replies:
Cool...sounds good - thanks for merging.
l
ur
e
se

@asfgit asfgit merged commit f5b5197 into apache:4.5 Sep 2, 2015
asfgit pushed a commit that referenced this pull request Sep 2, 2015
Support live migration on older version of Libvirthttps://issues.apache.org/jira/browse/CLOUDSTACK-8792

A flag being passed to Libvirt assumes v1.0.0 or later.

We need to put a check in the code to pass in a different flag if the version of Libvirt is < 1.0.0.

* pr/771:
  Support live migration on older version of Libvirt

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@mike-tutkowski mike-tutkowski deleted the 4.5 branch September 3, 2015 18:42
yadvr pushed a commit that referenced this pull request Jan 20, 2021
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants