github-actions: fix ui build workflow#7522
Merged
Merged
Conversation
package-lock.json is not removed. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
weizhouapache
approved these changes
May 12, 2023
weizhouapache
left a comment
Member
There was a problem hiding this comment.
code lgtm
I wonder if we need to remove this file from code base if it is updated or generated during the building process (not only in github action, but also in packaging jobs, etc)
yadvr
approved these changes
May 12, 2023
Member
|
@weizhouapache we don't remove the lock file in our packaging jobs that's why packaging jobs pass. |
Member
|
I've noticed between v14 and newer, the lock file format (version number) changes. |
Member
@rohityadavcloud indeed we do not remove the lock file in debian/rules and packaging/centos8/cloud.spec and it works. why the file should be removed to fix ui build workflow in github actions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
package-lock.json is not removed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?