Skip to content

use fakelocalhost in BasicRestClientTest#752

Merged
asfgit merged 1 commit into
apache:masterfrom
ustcweizhou:BasicRestClientTest-fakelocalhost
Aug 28, 2015
Merged

use fakelocalhost in BasicRestClientTest#752
asfgit merged 1 commit into
apache:masterfrom
ustcweizhou:BasicRestClientTest-fakelocalhost

Conversation

@ustcweizhou
Copy link
Copy Markdown
Contributor

@ustcweizhou ustcweizhou commented Aug 27, 2015

BasicRestClientTest will fail if the port 443 is open on localhost.
use fakelocalhost instead of localhost can fix it.
Please see the latest discussion in #737

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 27, 2015

cloudstack-pull-rats #421 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 27, 2015

cloudstack-pull-analysis #354 ABORTED

@karuturi
Copy link
Copy Markdown
Member

karuturi commented Aug 28, 2015

👍

@miguelaferreira
Copy link
Copy Markdown
Contributor

miguelaferreira commented Aug 28, 2015

Ran all unit tests in that module and all passed:

mvn clean install -P developer,systemvm -pl :cloud-utils

[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache CloudStack Utils 4.6.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
...
Results :

Tests run: 152, Failures: 0, Errors: 0, Skipped: 13
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19.638 s
[INFO] Finished at: 2015-08-28T14:57:07+02:00
[INFO] Final Memory: 63M/574M
[INFO] ------------------------------------------------------------------------

👍

@asfgit asfgit merged commit 5e792e3 into apache:master Aug 28, 2015
asfgit pushed a commit that referenced this pull request Aug 28, 2015
@karuturi
Merge pull request #752 from ustcweizhou/BasicRestClientTest-fakeloca…
f5a7395 
…lhost

use fakelocalhost in BasicRestClientTestBasicRestClientTest will fail if the port 443 is open on localhost.
use fakelocalhost instead of localhost can fix it.
Please see the latest discussion in #737

* pr/752:
  use fakelocalhost in BasicRestClientTest

Signed-off-by: Rajani Karuturi <rajani.karuturi@citrix.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@yadvr
custom: fix background color of navigation with domain/user has logge…
fea280e 
…d. (#752)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ustcweizhou @asfbot @karuturi @miguelaferreira @asfgit