Skip to content

Fix console access on XCPng/Xen#7243

Merged
weizhouapache merged 1 commit into
apache:mainfrom
shapeblue:fix-xcpng-console
Feb 17, 2023
Merged

Fix console access on XCPng/Xen#7243
weizhouapache merged 1 commit into
apache:mainfrom
shapeblue:fix-xcpng-console

Conversation

@nvazquez

@nvazquez nvazquez commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

Description

This PR fixes the console access on XCPng/XenServer observed on the 4.18 RC1 (fixing the RFB protocol version for tunnel connection after PR #7015 was merged)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

View any VM console

@nvazquez nvazquez added this to the 4.18.0.0 milestone Feb 16, 2023
@nvazquez nvazquez changed the title Fix console proxy on XCPng/Xen Fix console access on XCPng/Xen Feb 16, 2023
@nvazquez

nvazquez commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Feb 16, 2023

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Feb 16, 2023

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5595

@weizhouapache

weizhouapache commented Feb 16, 2023

Copy link
Copy Markdown
Member

@blueorangutan test centos7 xcpng82 keepEnv

@blueorangutan

blueorangutan commented Feb 16, 2023

Copy link
Copy Markdown

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

@sonarqubecloud

sonarqubecloud Bot commented Feb 17, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

harikrishna-patnala
harikrishna-patnala approved these changes Feb 17, 2023
View reviewed changes

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could reproduce the issue where the console is always in the connecting state.
I've also verified this fix, console is working.
image

weizhouapache
weizhouapache approved these changes Feb 17, 2023
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified OK with xcpng82

vladimirpetrov
vladimirpetrov approved these changes Feb 17, 2023
View reviewed changes

@vladimirpetrov vladimirpetrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing. Tested upgrade from ACS 4.16 XenServer 7.4 and MS OS CentOS 7.

@weizhouapache weizhouapache merged commit 4956648 into apache:main Feb 17, 2023
@DaanHoogland DaanHoogland deleted the fix-xcpng-console branch February 17, 2023 10:21
@blueorangutan

blueorangutan commented Feb 17, 2023

Copy link
Copy Markdown

Trillian test result (tid-6190)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 67375 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7243-t6190-xcpng82.zip
Smoke tests completed. 102 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_volume_usage Error 93.63 test_usage.py
test_08_upgrade_kubernetes_ha_cluster Error 4121.53 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.05 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 96.94 test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity Error 169.50 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 105.92 test_nonstrict_affinity_group.py
test_deploy_vm_with_registered_userdata Error 783.49 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 786.64 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append Error 823.98 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params Error 857.61 test_register_userdata.py
test_list_vms_metrics_admin Error 0.20 test_metrics_api.py
test_list_vms_metrics_history Error 0.18 test_metrics_api.py
test_list_volumes_metrics_history Error 0.16 test_metrics_api.py
test_01_deploy_vm_on_specific_host Error 0.09 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 0.06 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 0.08 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 0.11 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 0.08 test_vm_deployment_planner.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes
@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes
@yadvr yadvr Awaiting requested review from yadvr
@shwstppr shwstppr Awaiting requested review from shwstppr
@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

component:console-proxy Severity:BLOCKER type:bug

Projects

None yet

Milestone

4.18.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nvazquez @blueorangutan @weizhouapache @harikrishna-patnala @vladimirpetrov