Skip to content

fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml#7163

Merged
weizhouapache merged 1 commit into
apache:4.17from
weizhouapache:4.17-fix-custom-build-on-ubuntu
May 8, 2023
Merged

fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml#7163
weizhouapache merged 1 commit into
apache:4.17from
weizhouapache:4.17-fix-custom-build-on-ubuntu

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Feb 2, 2023

Steps to reproduce the issue

(1) on ubuntu server, run "git checkout 4.17.2.0"
(2) packaging
cd packaging/
./build-deb.sh -b test1

expected result: succeed
actual result:

[ERROR] The build could not read 1 project -> [Help 1] [ERROR]
[ERROR] The project org.apache.cloudstack:cloud-apidoc:4.17.2.0-test1-test1 (/data/cloudstack/tools/apidoc/pom.xml) has 1 error
[ERROR] Non-resolvable parent POM for org.apache.cloudstack:cloud-apidoc:4.17.2.0-test1-test1: Could not find artifact org.apache.cloudstack:cloud-tools:pom:4.17.2.0-test1-test1 in central (https://repo.maven.apache.org/maven2) and 'parent.relativePath' points at wrong local POM @ line 25, column 13 -> [Help 2]

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml
41f76e3 
Steps to reproduce the issue

(1) on ubuntu server, run "git checkout 4.17.2.0"
(2) packaging
cd packaging/
./build-deb.sh -b test1

expected result: succeed
actual result:

[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project org.apache.cloudstack:cloud-apidoc:4.17.2.0-test1-test1 (/data/cloudstack/tools/apidoc/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for org.apache.cloudstack:cloud-apidoc:4.17.2.0-test1-test1: Could not find artifact org.apache.cloudstack:cloud-tools:pom:4.17.2.0-test1-test1 in central (https://repo.maven.apache.org/maven2) and 'parent.relativePath' points at wrong local POM @ line 25, column 13 -> [Help 2]
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2023 •
edited
Loading

Codecov Report

Merging #7163 (41f76e3) into 4.17 (e1d3657) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #7163   +/-   ##
=========================================
  Coverage     10.37%   10.37%           
  Complexity     6650     6650           
=========================================
  Files          2453     2453           
  Lines        242439   242439           
  Branches      37938    37938           
=========================================
  Hits          25164    25164           
  Misses       214165   214165           
  Partials       3110     3110

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yadvr
yadvr reviewed Feb 3, 2023
View reviewed changes
Comment thread tools/build/setnextversion.sh
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 7, 2023

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 7, 2023

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 7, 2023

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5518

DaanHoogland
DaanHoogland approved these changes Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and looks good

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 8, 2023

@wido did you guys face this as well?
@rohityadavcloud do you approve?

@yadvr yadvr added this to the 4.18.1.0 milestone Apr 11, 2023
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Apr 11, 2023

@shwstppr can you review/test?

@yadvr yadvr requested a review from shwstppr April 11, 2023 11:34
@yadvr
Copy link
Copy Markdown
Member

yadvr commented May 8, 2023

ping @shwstppr can you verify/test and help merge it? Thanks.

shwstppr
shwstppr approved these changes May 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Ubuntu 20.04 with build script

@weizhouapache weizhouapache merged commit ea2b537 into apache:4.17 May 8, 2023
@weizhouapache weizhouapache deleted the 4.17-fix-custom-build-on-ubuntu branch June 23, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @DaanHoogland @blueorangutan @yadvr @shwstppr