Skip to content

UI: display cpu cores and speed instead of cputotal by default#7106

Merged
DaanHoogland merged 1 commit into
apache:4.17from
weizhouapache:4.17-issue-7105
Jan 18, 2023
Merged

UI: display cpu cores and speed instead of cputotal by default#7106
DaanHoogland merged 1 commit into
apache:4.17from
weizhouapache:4.17-issue-7105

Conversation

@weizhouapache

@weizhouapache weizhouapache commented Jan 18, 2023

Copy link
Copy Markdown
Member

Description

This PR fixes #7105

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@weizhouapache weizhouapache added this to the 4.18.0.0 milestone Jan 18, 2023
@weizhouapache weizhouapache linked an issue Jan 18, 2023 that may be closed by this pull request
Primate UI is missing core count for VM instances #7105
Closed
@yadvr

yadvr commented Jan 18, 2023

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

blueorangutan commented Jan 18, 2023

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jan 18, 2023

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7106 (QA-JID-31)

@codecov

codecov Bot commented Jan 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7106 (5734084) into 4.17 (3dc0e49) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #7106   +/-   ##
=========================================
  Coverage     10.37%   10.37%           
- Complexity     6643     6645    +2     
=========================================
  Files          2453     2453           
  Lines        242410   242410           
  Branches      37933    37933           
=========================================
+ Hits          25139    25143    +4     
+ Misses       214165   214160    -5     
- Partials       3106     3107    +1
Impacted Files Coverage Δ
...dstack/network/contrail/model/ModelObjectBase.java 28.84% <0.00%> (+7.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland

DaanHoogland commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

tested in qa:
image

@DaanHoogland DaanHoogland merged commit fe0e44a into apache:4.17 Jan 18, 2023
@DaanHoogland DaanHoogland mentioned this pull request Jan 18, 2023
Closed
DaanHoogland added a commit that referenced this pull request Jan 18, 2023
@DaanHoogland
Merge release branch 4.17 to main
ee6ed21 
* 4.17:
  KVM: revert libvirtd config and retry if fail to add a host (#7090)
  UI: display cpu cores and speed instead of cputotal by default (#7106)
  storage: validate disk size range of custom disk offering when resize volume (#7073)
stephankruggg pushed a commit to scclouds/cloudstack that referenced this pull request Jan 25, 2023
@weizhouapache
UI: display cpu cores and speed instead of cputotal by default (apach…
a0afd1b 
…e#7106)
@weizhouapache weizhouapache deleted the 4.17-issue-7105 branch January 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@NuxRo NuxRo Awaiting requested review from NuxRo

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.18.0.0

Development

Successfully merging this pull request may close these issues.

Primate UI is missing core count for VM instances

5 participants

@weizhouapache @yadvr @blueorangutan @DaanHoogland @shwstppr