Skip to content

CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a new VM#683

Merged
asfgit merged 3 commits into
apache:masterfrom
pavanb018:multivol
Sep 23, 2015
Merged

CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a new VM#683
asfgit merged 3 commits into
apache:masterfrom
pavanb018:multivol

Conversation

@pavanb018
Copy link
Copy Markdown
Contributor

Attach multiple Volumes simultaneously to a Running VM ... === TestName: test_attach_multiple_volumes | Status : SUCCESS ===
ok


Ran 1 test in 196.931s

OK

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 12, 2015

cloudstack-pull-rats #268 SUCCESS
This pull request looks good

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you want to list only data disk , add parameter type=DATADISK

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 12, 2015

cloudstack-pull-requests #965 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 12, 2015

cloudstack-pull-rats #271 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 12, 2015

cloudstack-pull-requests #968 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 12, 2015

cloudstack-pull-analysis #201 ABORTED

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 12, 2015

cloudstack-pull-analysis #204 SUCCESS
This pull request looks good

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it think it is better to deiced if you want to skip as early as possible.
in this case it will be good to skip test cases before deploy vm /create acc /service off

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 13, 2015

cloudstack-pull-rats #280 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 13, 2015

cloudstack-pull-requests #977 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 13, 2015

cloudstack-pull-analysis #213 SUCCESS
This pull request looks good

@nitt10prashant
Copy link
Copy Markdown
Contributor

LGTM

@remibergsma
Copy link
Copy Markdown
Contributor

@pavanb018 Can you please squash the commits?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not catching the return value of the query_asyn_job method. We can fail the test here if the return value is FAILED. Feel free to comment if you don't agree with this.

@pavanb018
Copy link
Copy Markdown
Contributor Author

The result of operation is captured in the list volume validation following the call to query_async_job method. Hence didn't capture the return value of call to function as it will be captured in the end validation. Please let me know your suggestions.

@asfbot
Copy link
Copy Markdown

asfbot commented Sep 23, 2015

Sanjeev N on dev@cloudstack.apache.org replies:
LGTM!!

bvbharatk pushed a commit to bvbharatk/cloudstack that referenced this pull request Sep 23, 2015
CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a new VMAttach multiple Volumes simultaneously to a Running VM ... === TestName: test_attach_multiple_volumes | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 196.931s

OK

* pr/683:
  changed the testcase skip code into setup method
  Imparting changes mentioned by nitt10prashant
  Automation for multiple disk attachments to instance

Signed-off-by: sanjeev <sanjeev@apache.org>
@asfgit asfgit merged commit 96b1a5c into apache:master Sep 23, 2015
yadvr pushed a commit that referenced this pull request Jan 20, 2021
According to docs, the router will be started as soon as
vpc is created. If user doent want it to start then they
need to explicity set it to false

Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants