Interface changes related to CLOUDSTACK-8580#680
Conversation
|
cloudstack-pull-rats #261 SUCCESS |
|
cloudstack-pull-requests #958 SUCCESS |
|
cloudstack-pull-analysis #194 SUCCESS |
|
@wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes related to #593. |
There was a problem hiding this comment.
I think the var name is explanatory. the comment could go with allocation and not use of the thingy.
|
please comment on testing the stuff, for instance ref unit - or integration tests that cover the code in the PR description/comment or, alternatively add unit tests. |
|
cloudstack-pull-rats #286 SUCCESS |
|
cloudstack-pull-requests #983 SUCCESS |
|
cloudstack-pull-analysis #219 UNSTABLE |
|
@borisroman Please squash the commits here as well |
e97ddc6 to
dd8c757
Compare
|
@remibergsma Done. |
|
cloudstack-pull-rats #288 SUCCESS |
|
cloudstack-pull-requests #985 SUCCESS |
|
cloudstack-pull-analysis #221 SUCCESS |
|
Code looks good to me, but I see there are still some outstanding comments? |
|
@wido my comments we're on outdated code. I will have another look |
There was a problem hiding this comment.
not really a comment that enlightens us beyond the naming of the variables, so could be omitted.
|
code LGTM, less comment is better in this case but I'll settle. |
Added responses to ListCapabilities to reflect CLOUDSTACK-8580 changes. This to add these options to the gui. See issue CLOUDSTACK-8580. https://github.com/kevindierkx/cloudstack/commit/3be14e978aa0c9b286d9f57bf1fc60ebe50990c7 Removed comments as proposed by Daan Hoogland.
dd8c757 to
655fcc9
Compare
|
@wido @DaanHoogland Removed last comments. |
|
cloudstack-pull-rats #299 SUCCESS |
|
cloudstack-pull-requests #995 SUCCESS |
|
@borisroman Great, looks like we're ready to go. I'll wait for Travis to turn green and then merge. |
Interface changes related to CLOUDSTACK-8580See issue CLOUDSTACK-8580 and individual commits. * pr/680: Made interface changes related to CLOUDSTACK-8580 Signed-off-by: Remi Bergsma <github@remi.nl>
See issue CLOUDSTACK-8580 and individual commits.