Skip to content

test,xcp-ng: fix tests for VM PV driver issue#6549

Merged
shwstppr merged 5 commits into
apache:4.17from
shapeblue:fix-xen-test-pv-template
Aug 9, 2022
Merged

test,xcp-ng: fix tests for VM PV driver issue#6549
shwstppr merged 5 commits into
apache:4.17from
shapeblue:fix-xen-test-pv-template

Conversation

@shwstppr

@shwstppr shwstppr commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Few of the smoke tests fail on XCP-ng8 with PV drivers not installed for the VM.
This PR makes changes to use get_suitable_test_template instead of get_template to use the appropriate template for the VM deployed during the test.
After volume migration VM becomes unusable for attach/detach volume action.
A new template could be used in future. For workaround right now, tests are ordered in a way that migrate volume test run at the end.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
test: fix tests for VM PV driver issue
ee0d6b0 
Few of the smoke tests fail on XCP-ng8 with PV drivers not installed for the VM.
This PR makes changes to use get_suitable_test_template instead of get_template to use appropriate template for the VM deployed during the test.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@boring-cyborg boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Jul 12, 2022
@shwstppr shwstppr added this to the 4.17.1.0 milestone Jul 25, 2022
@shwstppr shwstppr mentioned this pull request Jul 25, 2022
Merged
5 tasks
@yadvr

yadvr commented Jul 27, 2022

Copy link
Copy Markdown
Member

ping @shwstppr is this ready for review/testing?

@shwstppr

shwstppr commented Jul 27, 2022

Copy link
Copy Markdown
Contributor Author

@rohityadavcloud not yet. Apart from test_attach_multiple_volumes.py there is also a failure in one of the tests of test_volumes.py. I'll check and try to fix that.

@shwstppr shwstppr self-assigned this Jul 29, 2022
@shwstppr
change order wrt migrate test
149d0d4 
After volume migration VM becomes unusable for attach/detach volume action.
A new template could be used in future. For workaround right now, tests are ordered in a way that migrate volume test run at the end

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@acs-robot

acs-robot commented Aug 5, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented Aug 5, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr

shwstppr commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Aug 5, 2022

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr shwstppr changed the title test: fix tests for VM PV driver issue test,xcp-ng: fix tests for VM PV driver issue Aug 5, 2022
@blueorangutan

blueorangutan commented Aug 5, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6549 (SL-JID-2083)

@shwstppr shwstppr marked this pull request as ready for review August 5, 2022 08:06
@blueorangutan

blueorangutan commented Aug 5, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3911

@shwstppr

shwstppr commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test centos7 xcpng82

@blueorangutan

blueorangutan commented Aug 5, 2022

Copy link
Copy Markdown

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Aug 6, 2022

Copy link
Copy Markdown

Trillian test result (tid-4623)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51881 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6549-t4623-xcpng82.zip
Smoke tests completed. 98 look OK, 3 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_volume_usage Error 97.72 test_usage.py
test_08_upgrade_kubernetes_ha_cluster Failure 740.10 test_kubernetes_clusters.py
test_03_network_operations_on_created_vm_of_otheruser Failure 192.07 test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser Error 192.08 test_network_permissions.py

@shwstppr

shwstppr commented Aug 6, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test centos7 xcpng82

@blueorangutan

blueorangutan commented Aug 6, 2022

Copy link
Copy Markdown

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Aug 7, 2022

Copy link
Copy Markdown

Trillian test result (tid-4631)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46246 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6549-t4631-xcpng82.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_network_operations_on_created_vm_of_otheruser Failure 196.71 test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser Error 196.72 test_network_permissions.py

@shwstppr
fix test
a2fbc6b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@github-actions

github-actions Bot commented Aug 8, 2022

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@shwstppr
fix
0757ea5 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from acs-robot Aug 8, 2022
@apache apache deleted a comment from blueorangutan Aug 8, 2022
@apache apache deleted a comment from acs-robot Aug 8, 2022
@apache apache deleted a comment from blueorangutan Aug 8, 2022
@apache apache deleted a comment from blueorangutan Aug 8, 2022
@apache apache deleted a comment from blueorangutan Aug 8, 2022
@shwstppr

shwstppr commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Aug 8, 2022

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud

sonarqubecloud Bot commented Aug 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blueorangutan

blueorangutan commented Aug 8, 2022

Copy link
Copy Markdown

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3931

@shwstppr

shwstppr commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Aug 8, 2022

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Aug 8, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3935

@shwstppr

shwstppr commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test centos7 xcpng82

@blueorangutan

blueorangutan commented Aug 8, 2022

Copy link
Copy Markdown

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

@shwstppr

shwstppr commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Aug 8, 2022

Copy link
Copy Markdown

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Aug 8, 2022

Copy link
Copy Markdown

Trillian test result (tid-4637)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48186 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6549-t4637-xcpng82.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan

blueorangutan commented Aug 9, 2022

Copy link
Copy Markdown

Trillian test result (tid-4655)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39672 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6549-t4655-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 584.26 test_kubernetes_clusters.py

@shwstppr

shwstppr commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

k8s upgrade cluster test error is unrelated and intermittent. Merging based on approvals and test results

@shwstppr shwstppr merged commit 404b579 into apache:4.17 Aug 9, 2022
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Sep 5, 2022
@shwstppr @neogismm
test,xcp-ng: fix tests for VM PV driver issue (apache#6549)
753b0d9 
Few of the smoke tests fail on XCP-ng8 with PV drivers not installed for the VM.
This PR makes changes to use get_suitable_test_template instead of get_template to use the appropriate template for the VM deployed during the test.
After volume migration VM becomes unusable for attach/detach volume action.
A new template could be used in future. For workaround right now, tests are ordered in a way that migrate volume test run at the end.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

@shwstppr shwstppr

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @yadvr @acs-robot @blueorangutan @DaanHoogland