Cloudstack 8656: do away with silently ignoring exceptions#649
Conversation
there was code to close a stream that was never created
|
cloudstack-pull-requests #873 FAILURE |
4e2f406 to
04e9083
Compare
|
cloudstack-pull-rats #175 ABORTED |
|
cloudstack-pull-rats #177 ABORTED |
|
cloudstack-pull-requests #875 ABORTED |
|
cloudstack-pull-analysis #108 SUCCESS |
|
cloudstack-pull-analysis #110 FAILURE |
|
cloudstack-pull-rats #178 ABORTED |
|
cloudstack-pull-requests #876 ABORTED |
|
cloudstack-pull-rats #179 ABORTED |
|
cloudstack-pull-analysis #111 SUCCESS |
|
cloudstack-pull-analysis #112 FAILURE |
|
cloudstack-pull-requests #877 ABORTED |
|
Aside from a few comments on 04e9083, LGTM. |
|
LGTM 👍 |
|
cloudstack-pull-requests #884 FAILURE |
|
cloudstack-pull-rats #186 ABORTED |
|
cloudstack-pull-analysis #119 ABORTED |
|
@mike-tutkowski are you alright with this now (merge-level allright;)? |
|
Mike Tutkowski on dev@cloudstack.apache.org replies: |
|
@mike-tutkowski sorry didn't notice your reply, I added a view more. Can you have a look? |
|
I just had a comment on 87ae150. |
35f4135 to
1f460f4
Compare
|
cloudstack-pull-rats #189 FAILURE |
|
two lgtm and succesful travis, merge gives no conflicts but will do a local build before push anyway |
|
cloudstack-pull-rats #188 ABORTED |
|
cloudstack-pull-analysis #121 FAILURE |
|
cloudstack-pull-requests #886 ABORTED |
|
cloudstack-pull-analysis #122 FAILURE |
|
cloudstack-pull-requests #887 ABORTED |
* pr/649: CLOUDSTACK-8656: checkstyle no longer used import removed CLOUDSTACK-8656: messages on SQL exception in DbUtils! CLOUDSTACK-8656: replace empty catch block on close by try-with-resource CLOUDSTACK-8656: 30x legacy upgrade code exception messages CLOUDSTACK-8656: removed redundant implements CLOUDSTACK-8656: silent close failure of clustering socket log as info CLOUDSTACK-8656: try with resource te eliminate empty catch clauses CLOUDSTACK-8656: log messages on exception in legacy sql upgrade code CLOUDSTACK-8656: removed unused input stream there was code to close a stream that was never created CLOUDSTACK-8656: info on error closing peering channels CLOUDSTACK-8656: messages on errors closing streams for local templates CLOUDSTACK-8656: handle template properties loading Signed-off-by: Daan Hoogland <daan@onecht.net>
|
cloudstack-pull-rats #192 FAILURE |
|
cloudstack-pull-analysis #125 ABORTED |
* Filter vms based on zones for attaching volumes * added custom view for filtering vms Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
No description provided.