Coverity Issue: Resource Leak fixed#643
Conversation
|
cloudstack-pull-rats #159 SUCCESS |
|
@kansal please add the coverity number to the commit message, this way we can not track it. And while you look at it make sure you put the issue on your name to prevent any double effort. I think we actually voted for not accepting any commits without ref anymore. |
There was a problem hiding this comment.
this return is not needed. we will fall through to other return. You can opt not to and put another log message in there as well. (no biggy)
|
cloudstack-pull-requests #857 SUCCESS |
|
@DaanHoogland It was the issue that was reported by our internal coverity. The issue reported is: "noescape: Resource 'in' is not closed or saved in readObject. |
|
cloudstack-pull-analysis #92 UNSTABLE |
|
-1 on this. I cannot track any internal tracking system of another company. please if the public coverity doesn't have this make a jira ticket describve the problem and put the ticket id in hte commit message. |
|
Hi @kansal If this issue was caught by your internal Coverity scan, wouldn't it also have been cough by the public Coverity scan? Or are these configured differently? It would be great to use the public IDs all-around, otherwise it will be very confusing. I can imagine many people have their own internal ticketing systems (for example), and if people would just start to use IDs from those internal systems it would be extremely hard to backtrack. Don't you think? |
|
@DaanHoogland @miguelaferreira I understand you concerns. I have created the ticket for this in JIRA with ID: CLOUDSTACK-8692. Will keep this in mind while for future commits. Thanks :) |
|
Cool 👍 |
|
Thanks @kansal , please change the commit message to point to it. For instance: Otherwise I'm all right with it |
…e at Citrix fixed.
|
cloudstack-pull-rats #180 ABORTED |
|
cloudstack-pull-requests #878 ABORTED |
|
cloudstack-pull-analysis #113 SUCCESS |
|
thanks @kansal LGTM (merging) |
Coverity Issue: Resource Leak fixed * pr/643: CLOUDSTACK-8692: Resource leak found by the internal coverity instance at Citrix fixed. Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
Fixes #643 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Resource leak fixed. Please review.