CLOUDSTACK-8689: Verify effect of changing value of XenServer Max guest limit by pritisarap12 · Pull Request #638 · apache/cloudstack

pritisarap12 · 2015-07-30T07:32:50Z

Verify effect of changing value of "Max guest limit" of XenServer on previously added hosts
-Check if it reads changed value and act accordingly

asfbot · 2015-07-30T07:35:19Z

cloudstack-pull-rats #153 SUCCESS
This pull request looks good

asfbot · 2015-07-30T07:48:58Z

cloudstack-pull-requests #851 SUCCESS
This pull request looks good

sanju1010 · 2015-07-30T08:28:19Z

If there are more than one host in a cluster, how can you make sure that all the vm deployments will go to the same host to test this functionality? IMO , it would be better to tag the host and try to deploy vms on it.

Also we need to check if there are any vms running on a chosen host(including system vms and guest vms) and then try to deploy the vms until we reach the max supported value.

Added the suggested changes
-Verify all VM's go to same host
-Count previously existing VM's on the selected host and then modify its "maxguestlimit"

asfbot · 2015-07-30T09:03:42Z

cloudstack-pull-analysis #86 SUCCESS
This pull request looks good

asfbot · 2015-07-30T11:41:29Z

cloudstack-pull-rats #161 SUCCESS
This pull request looks good

…st limitis on previously added hosts

asfbot · 2015-07-30T11:48:39Z

cloudstack-pull-rats #162 SUCCESS
This pull request looks good

asfbot · 2015-07-30T11:57:10Z

cloudstack-pull-requests #859 SUCCESS
This pull request looks good

asfbot · 2015-07-30T12:05:13Z

cloudstack-pull-requests #860 SUCCESS
This pull request looks good

asfbot · 2015-07-30T13:18:06Z

cloudstack-pull-analysis #94 SUCCESS
This pull request looks good

asfbot · 2015-07-30T13:20:31Z

cloudstack-pull-analysis #95 SUCCESS
This pull request looks good

nitt10prashant · 2015-07-31T07:13:10Z

can you post test results ?

asfbot · 2015-07-31T08:24:47Z

cloudstack-pull-rats #168 SUCCESS
This pull request looks good

pritisarap12 · 2015-07-31T08:25:11Z

Modified test to check for empty vmList and updating maxguestlimit accordingly.
And the test result is-

Test hypervisor max limits effect ... === TestName: test_check_hypervisor_max_limit_effect | Status : SUCCESS ===
ok

Ran 1 test in 142.770s

OK

sanju1010 · 2015-07-31T08:25:52Z

If we assume that there are 2 SSVMs and 1 VR on the host then vmCount becomes 3. You are adding 4 to vmCount. So newValue becomes 7. That means max. guest limit on the host is 7.

listVirtualMachines API does not list 2 SSVMs and 1 VR it only list the User deployed VM's hence I am adding 4 to vmCount.

asfbot · 2015-07-31T08:32:59Z

Sanjeev N on dev@cloudstack.apache.org replies:
How your logic works if there are no system vms on a host (ssvm, cpvm and
VR)? I mean if the cluster has more than one host and system vms were
deployed on another host in the cluster?

asfbot · 2015-07-31T08:38:40Z

cloudstack-pull-requests #866 SUCCESS
This pull request looks good

asfbot · 2015-07-31T09:36:10Z

cloudstack-pull-analysis #101 SUCCESS
This pull request looks good

…t-limitis-on-previously-added-hosts -Addning check for empty list and increamenting maxguestlimit accordingly

asfbot · 2015-07-31T10:17:21Z

cloudstack-pull-rats #170 SUCCESS
This pull request looks good

pritisarap12 · 2015-07-31T10:24:36Z

Updated the testcase for:
-Count SSVM's on selected host
-Count VR on the host
-Count user VM's on the host
-Then update the maxguestlimit for that host as(ssvm+vr+user_vm+1)
-Added validateList for host list

pritisarap12 · 2015-07-31T10:27:03Z

Testcase Result-

Test hypervisor max limits effect ... === TestName: test_check_hypervisor_max_limit_effect | Status : SUCCESS ===
ok

Ran 1 test in 159.787s

OK

asfbot · 2015-07-31T10:32:09Z

cloudstack-pull-requests #868 SUCCESS
This pull request looks good

nitt10prashant · 2015-07-31T11:12:35Z

LGTM

asfbot · 2015-07-31T11:31:45Z

cloudstack-pull-analysis #103 SUCCESS
This pull request looks good

asfbot · 2015-07-31T12:08:49Z

Sanjeev N on dev@cloudstack.apache.org replies:
LGTM

asfbot · 2015-08-03T06:33:24Z

cloudstack-pull-rats #182 FAILURE
Looks like there's a problem with this pull request

…tlimits on previously added hosts -As testcase is changing maxguestlimits global setting it will affect on other testcases also hence moving it to component/maint folder

asfbot · 2015-08-03T06:33:59Z

cloudstack-pull-requests #880 FAILURE
Looks like there's a problem with this pull request

asfbot · 2015-08-03T07:36:25Z

cloudstack-pull-rats #183 ABORTED

asfbot · 2015-08-03T07:51:45Z

cloudstack-pull-requests #881 ABORTED

asfbot · 2015-08-03T08:51:06Z

cloudstack-pull-analysis #115 SUCCESS
This pull request looks good

asfbot · 2015-08-03T08:51:42Z

cloudstack-pull-analysis #116 FAILURE
Looks like there's a problem with this pull request

… on (#638) Remove the primary store on which the volume is currently present on from the list of possible storage pools to migrate volume. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

sanju1010 reviewed Jul 30, 2015
View reviewed changes

pritisarap12 force-pushed the CLOUDSTACK-8689-Verify-effect-of-changing-value-of-XenServer-Max-guest-limitis-on-previously-added-hosts branch from e2c578f to 2705232 Compare July 30, 2015 11:39

CLOUDSTACK-8689: Verify effect of changing value of XenServer Max gue…

0c81b51

…st limitis on previously added hosts

pritisarap12 force-pushed the CLOUDSTACK-8689-Verify-effect-of-changing-value-of-XenServer-Max-guest-limitis-on-previously-added-hosts branch from 2705232 to 0c81b51 Compare July 30, 2015 11:46

sanju1010 reviewed Jul 31, 2015
View reviewed changes

CLOUDSTACK-8689-Verify-effect-of-changing-value-of-XenServer-Max-gues…

15785b3

…t-limitis-on-previously-added-hosts -Addning check for empty list and increamenting maxguestlimit accordingly

pritisarap12 force-pushed the CLOUDSTACK-8689-Verify-effect-of-changing-value-of-XenServer-Max-guest-limitis-on-previously-added-hosts branch from 54f6714 to 15785b3 Compare July 31, 2015 10:14

CLOUDSTACK-8689: Verify effect of changing value of XenServer Maxgues…

d9013d1

…tlimits on previously added hosts -As testcase is changing maxguestlimits global setting it will affect on other testcases also hence moving it to component/maint folder

pritisarap12 force-pushed the CLOUDSTACK-8689-Verify-effect-of-changing-value-of-XenServer-Max-guest-limitis-on-previously-added-hosts branch from 20b1e4a to d9013d1 Compare August 3, 2015 06:34

asfgit closed this in c5ebb68 Aug 3, 2015

Conversation

pritisarap12 commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

sanju1010 Jul 30, 2015

Choose a reason for hiding this comment

Uh oh!

sanju1010 Jul 30, 2015

Choose a reason for hiding this comment

Uh oh!

pritisarap12 Jul 30, 2015

Choose a reason for hiding this comment

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

asfbot commented Jul 30, 2015

Uh oh!

nitt10prashant commented Jul 31, 2015

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

pritisarap12 commented Jul 31, 2015

Uh oh!

sanju1010 Jul 31, 2015

Choose a reason for hiding this comment

Uh oh!

pritisarap12 Jul 31, 2015

Choose a reason for hiding this comment

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

pritisarap12 commented Jul 31, 2015

Uh oh!

pritisarap12 commented Jul 31, 2015

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

nitt10prashant commented Jul 31, 2015

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

asfbot commented Jul 31, 2015

Uh oh!

asfbot commented Aug 3, 2015

Uh oh!

asfbot commented Aug 3, 2015

Uh oh!

asfbot commented Aug 3, 2015

Uh oh!

asfbot commented Aug 3, 2015

Uh oh!

asfbot commented Aug 3, 2015

Uh oh!

asfbot commented Aug 3, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development