UI: Upgrade ant-design-vue to version 3.x by utchoang · Pull Request #6369 · apache/cloudstack

utchoang · 2022-05-10T04:24:55Z

Description

This PR for Fixes #6342. Upgrade ant-design-vue to version 3.x. Related https://www.antdv.com/docs/vue/migration-v3.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

acs-robot · 2022-05-10T04:25:52Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-10T04:27:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

acs-robot · 2022-05-10T04:33:48Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-10T04:34:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-05-10T04:34:29Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-1537)

blueorangutan · 2022-05-10T04:40:59Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-1538)

acs-robot · 2022-05-10T09:13:40Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-10T09:14:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-05-10T09:20:07Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-1540)

acs-robot · 2022-05-11T03:09:38Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-11T03:11:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-05-11T03:17:58Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-1545)

acs-robot · 2022-05-13T05:59:40Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

utchoang · 2022-05-13T09:03:51Z

@blueorangutan ui

blueorangutan · 2022-05-13T09:06:03Z

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-05-13T09:13:10Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-1571)

acs-robot · 2022-05-17T08:14:36Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

acs-robot · 2022-08-10T04:08:23Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

# Conflicts: # ui/src/components/view/ListView.vue

blueorangutan · 2022-08-10T04:09:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-10T04:15:40Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-2123)

github-actions · 2022-08-16T13:15:52Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

codecov · 2022-08-17T00:42:45Z

Codecov Report

Merging #6369 (b39b954) into main (78b68fd) will increase coverage by 4.39%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #6369      +/-   ##
============================================
+ Coverage      5.89%   10.29%   +4.39%     
- Complexity     3945     6781    +2836     
============================================
  Files          2454     2469      +15     
  Lines        242975   264123   +21148     
  Branches      38036    46029    +7993     
============================================
+ Hits          14323    27191   +12868     
- Misses       227064   233560    +6496     
- Partials       1588     3372    +1784

Impacted Files	Coverage Δ
...rce/wrapper/LibvirtResizeVolumeCommandWrapper.java	`59.84% <0.00%> (-16.82%)`	⬇️
.../cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java	`74.57% <0.00%> (-6.68%)`	⬇️
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java	`40.22% <0.00%> (-6.19%)`	⬇️
...apache/cloudstack/syslog/AlertsSyslogAppender.java	`56.49% <0.00%> (-2.26%)`	⬇️
...apache/cloudstack/storage/volume/VolumeObject.java	`36.69% <0.00%> (-1.67%)`	⬇️
...CreatePrivateTemplateFromVolumeCommandWrapper.java	`14.81% <0.00%> (-0.19%)`	⬇️
...java/org/apache/cloudstack/utils/qemu/QemuImg.java	`2.69% <0.00%> (-0.10%)`	⬇️
...java/com/cloud/hypervisor/vmware/mo/ClusterMO.java	`0.22% <0.00%> (-0.04%)`	⬇️
.../hypervisor/kvm/storage/KVMStoragePoolManager.java	`0.48% <0.00%> (-0.01%)`	⬇️
...ain/java/com/cloud/consoleproxy/AgentHookBase.java	`0.00% <0.00%> (ø)`
... and 517 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

acs-robot · 2022-08-17T00:43:06Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-17T00:44:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-17T00:50:51Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-2162)

github-actions · 2022-09-10T10:35:59Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

yadvr · 2022-10-08T06:44:34Z

@utchoang can you confirm if you've done a round of full tests [1] as root admin, domain admin and normal account user. Very interested to getting this in soon, thanks for your PR.

[1] see https://github.com/apache/cloudstack/blob/main/ui/docs/full-test-plan.template.md

utchoang · 2022-10-10T02:44:27Z

@rohityadavcloud Starting today, I will stop working at Cloudstack due to a job change. I will leave this PR as a reference for the following members. Hopefully, it will help other members continue with this.

yadvr · 2022-10-10T07:36:05Z

@utchoang thanks for letting us know, I hope to see you around (psst. we're hiring in case ;)).

github-actions · 2022-10-27T21:04:13Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

yadvr · 2023-03-02T08:05:26Z

Closing this as this is continued at #7306

Continuation of #6369 This PR for Fixes #6342. Upgrade ant-design-vue to version 3.x. Related https://www.antdv.com/docs/vue/migration-v3. Co-authored-by: utchoang <hoangnm@unitech.vn>

utchoang added 4 commits May 5, 2022 16:12

fix table warning after migration

1b83f8b

fix logout error

cd24751

fixes UT

faa77f3

revert coverage flag

66d4edc

boring-cyborg Bot added the component:UI label May 10, 2022

update dependencies

40ea060

revert dependencies

1b1c261

fix UT errors

bd920e3

fixes clear notification

e0ced65

utchoang added 3 commits May 16, 2022 12:53

Merge branch 'main-upstream' into feature/ui-migrate-ant-design

b1fd1a8

fix treeview & dragable

587e550

fix auto-select treeNode

d3db181

apache deleted a comment from sonarqubecloud Bot May 17, 2022

Merge branch 'main-upstream' into feature/ui-migrate-ant-design

d3bd980

# Conflicts: # ui/src/components/view/ListView.vue

github-actions Bot added the status:has-conflicts label Aug 16, 2022

Merge branch 'main' into feature/ui-migrate-ant-design

fdad8eb

github-actions Bot removed the status:has-conflicts label Aug 17, 2022

github-actions Bot added the status:has-conflicts label Sep 10, 2022

Merge branch 'main' into feature/ui-migrate-ant-design

b39b954

github-actions Bot removed the status:has-conflicts label Sep 12, 2022

utchoang closed this Oct 10, 2022

utchoang reopened this Oct 10, 2022

github-actions Bot added the status:has-conflicts label Oct 27, 2022

DaanHoogland modified the milestones: 4.18.0.0, 4.19.0.0 Oct 28, 2022

davidjumani mentioned this pull request Mar 2, 2023

Ant3 upgrade #7306

Merged

12 tasks

yadvr closed this Mar 2, 2023

yadvr removed this from the 4.19.0.0 milestone Mar 13, 2023

yadvr pushed a commit that referenced this pull request Apr 11, 2023

ui: AntD3 upgrade (#7306)

3c25a35

Continuation of #6369 This PR for Fixes #6342. Upgrade ant-design-vue to version 3.x. Related https://www.antdv.com/docs/vue/migration-v3. Co-authored-by: utchoang <hoangnm@unitech.vn>

Uh oh!

Conversation

utchoang commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

acs-robot commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

acs-robot commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

blueorangutan commented May 10, 2022

Uh oh!

acs-robot commented May 11, 2022

Uh oh!

blueorangutan commented May 11, 2022

Uh oh!

blueorangutan commented May 11, 2022

Uh oh!

acs-robot commented May 13, 2022

Uh oh!

utchoang commented May 13, 2022

Uh oh!

blueorangutan commented May 13, 2022

Uh oh!

blueorangutan commented May 13, 2022

Uh oh!

acs-robot commented May 17, 2022

Uh oh!

acs-robot commented Aug 10, 2022

Uh oh!

blueorangutan commented Aug 10, 2022

Uh oh!

blueorangutan commented Aug 10, 2022

Uh oh!

github-actions Bot commented Aug 16, 2022

Uh oh!

codecov Bot commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

acs-robot commented Aug 17, 2022

Uh oh!

blueorangutan commented Aug 17, 2022

Uh oh!

blueorangutan commented Aug 17, 2022

Uh oh!

github-actions Bot commented Sep 10, 2022

Uh oh!

yadvr commented Oct 8, 2022

Uh oh!

utchoang commented Oct 10, 2022

Uh oh!

yadvr commented Oct 10, 2022

Uh oh!

github-actions Bot commented Oct 27, 2022

Uh oh!

yadvr commented Mar 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

utchoang commented May 10, 2022 •

edited

Loading

codecov Bot commented Aug 17, 2022 •

edited

Loading