Skip to content

unittesting: test resolution is not guaranteed to be exact#633

Merged
asfgit merged 1 commit into
apache:masterfrom
DaanHoogland:test-resolution
Jul 29, 2015
Merged

unittesting: test resolution is not guaranteed to be exact#633
asfgit merged 1 commit into
apache:masterfrom
DaanHoogland:test-resolution

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Jul 29, 2015

a lot of validation pull requests are failing over this test. It should pass but it's failure is environmental in any observed case so far.

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 29, 2015

cloudstack-pull-rats #145 SUCCESS
This pull request looks good

@wilderrodrigues
Copy link
Copy Markdown
Contributor

wilderrodrigues commented Jul 29, 2015

Thanks, @DaanHoogland!

LGTM 👍

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 29, 2015

LGTM

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 29, 2015

cloudstack-pull-requests #843 SUCCESS
This pull request looks good

@asfgit asfgit merged commit 2c110ab into apache:master Jul 29, 2015
@asfbot
Copy link
Copy Markdown

asfbot commented Jul 29, 2015

cloudstack-pull-analysis #78 ABORTED

@DaanHoogland DaanHoogland deleted the test-resolution branch August 14, 2015 17:05
@miguelaferreira
Copy link
Copy Markdown
Contributor

miguelaferreira commented Aug 26, 2015

@DaanHoogland @wilderrodrigues @bhaisaab

What's the purpose of having this unit test?

I've just seen this unit test fail in a travis build (https://travis-ci.org/miguelaferreira/cloudstack/jobs/77300485). What needs to be done in response to this failure?

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Aug 26, 2015

@miguelaferreira it is proven to be of no use. For what I am concerned we should remove it totally. We can not guarantee any kind of realtime result in/with this test.
The period checked for had been lengthened beyond the 2 ms. If we lengthen the test period over 3 milisecs when testing 2 there is no longer any test being done.

@miguelaferreira
Copy link
Copy Markdown
Contributor

miguelaferreira commented Aug 26, 2015

@DaanHoogland: @wilderrodrigues will make a PR to remove it

yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
compute: Fixing networks not shown selected (#633)
91cc0d1 
Fixes #618

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DaanHoogland @asfbot @wilderrodrigues @yadvr @miguelaferreira @asfgit