Skip to content

CLOUDSTACK-8686:Verify data disk attachment for clusters with only zone wide primary#631

Closed
pritisarap12 wants to merge 1 commit into
apache:masterfrom
pritisarap12:CLOUDSTACK-8686-Data-disk-attach-failed-for-clusters-with-only-zone-wide-primary
Closed

CLOUDSTACK-8686:Verify data disk attachment for clusters with only zone wide primary#631
pritisarap12 wants to merge 1 commit into
apache:masterfrom
pritisarap12:CLOUDSTACK-8686-Data-disk-attach-failed-for-clusters-with-only-zone-wide-primary

Conversation

@pritisarap12
Copy link
Copy Markdown

@pritisarap12 pritisarap12 commented Jul 29, 2015

-Attaching the uploaded/allocated volume to a VM on zwps

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 29, 2015

cloudstack-pull-rats #142 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 29, 2015

cloudstack-pull-requests #840 SUCCESS
This pull request looks good

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 29, 2015

I can only judge this on code cleanliness. An added pep8 pull request builder might help;) @pritisarap12 please solicit review from test experts that have access to the required hardware (zwmp?) or add verification instructions for no-knows like me to test this.
Thanks

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 29, 2015

cloudstack-pull-analysis #75 UNSTABLE
Looks like there's a problem with this pull request

sanju1010
sanju1010 reviewed Jul 29, 2015
View reviewed changes
Comment thread test/integration/testpaths/testpath_attach_disk_zwps.py Outdated
Copy link
Copy Markdown
Contributor

@sanju1010 sanju1010 Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please point me to the code where it gets the zwps?

Copy link
Copy Markdown
Author

@pritisarap12 pritisarap12 Jul 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missed code to check Zone wide primary storage and adding tags to storage pools with scope="Zone"

@pritisarap12 pritisarap12 force-pushed the CLOUDSTACK-8686-Data-disk-attach-failed-for-clusters-with-only-zone-wide-primary branch from 608fff5 to 0f75937 Compare July 31, 2015 05:35
@asfbot
Copy link
Copy Markdown

asfbot commented Jul 31, 2015

cloudstack-pull-rats #164 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 31, 2015

cloudstack-pull-requests #862 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 31, 2015

cloudstack-pull-analysis #97 SUCCESS
This pull request looks good

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 31, 2015

All is green and as there is no other reviews and all tests are green, I am going to say: LGTM. But please someone that understands the full ramifications of the test verify. 👍

sanju1010
sanju1010 reviewed Jul 31, 2015
View reviewed changes
Comment thread test/integration/testpaths/testpath_attach_disk_zwps.py Outdated
Copy link
Copy Markdown
Contributor

@sanju1010 sanju1010 Jul 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In stead of failing the test if there are no zone wide primary storage in the setup, can you skip the test?

CLOUDSTACK-8686: Data disk attach failed for clusters with only zone …
2b018d2 
…wide primary

	-Attaching the uploaded/allocated volume to a VM on zwps
@pritisarap12 pritisarap12 force-pushed the CLOUDSTACK-8686-Data-disk-attach-failed-for-clusters-with-only-zone-wide-primary branch from 0f75937 to 2b018d2 Compare August 3, 2015 06:12
@asfbot
Copy link
Copy Markdown

asfbot commented Aug 3, 2015

cloudstack-pull-rats #181 ABORTED

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 3, 2015

cloudstack-pull-requests #879 ABORTED

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 3, 2015

cloudstack-pull-analysis #114 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 3, 2015

Sanjeev N on dev@cloudstack.apache.org replies:
LGTM!!

@asfgit asfgit closed this in b6a06b4 Aug 3, 2015
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@yadvr
views: add maskClosable=false to keep form/modal when clicked outsi…
151f685 
…de (#631)

Fixes #629

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pritisarap12 @asfbot @DaanHoogland @sanju1010