Skip to content

ui: fix vpc tier redirect to show details#6178

Merged
weizhouapache merged 3 commits into
apache:mainfrom
shapeblue:fix-ui-vpctier-redirect
Mar 31, 2022
Merged

ui: fix vpc tier redirect to show details#6178
weizhouapache merged 3 commits into
apache:mainfrom
shapeblue:fix-ui-vpctier-redirect

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

Description

When redirecting to VPC tier from VPC view, details tab should be active by default

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before:
Screenshot from 2022-03-30 13-31-08

After:
Screenshot from 2022-03-30 13-31-26

How Has This Been Tested?

When redirecting to VPC tier, details tab should be active by default

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr shwstppr requested a review from weizhouapache March 30, 2022 08:05
@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6178 (SL-JID-1317)

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok

@weizhouapache
Copy link
Copy Markdown
Member

@shwstppr
can you fix other tabs in vpc ? it looks all other tabs have the same issue.

network acl, private gateway, s2s vpn, etc

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok !!

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6178 (SL-JID-1321)

@weizhouapache weizhouapache added this to the 4.17.0.0 milestone Mar 31, 2022
@weizhouapache weizhouapache merged commit e339c4b into apache:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants