Skip to content

UI: fix update public IP ranges#6177

Merged
weizhouapache merged 1 commit into
apache:mainfrom
weizhouapache:4.17-ui-fix-update-public-ip
Mar 29, 2022
Merged

UI: fix update public IP ranges#6177
weizhouapache merged 1 commit into
apache:mainfrom
weizhouapache:4.17-ui-fix-update-public-ip

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Mar 29, 2022

Description

This PR fixes the error when update public IP ranges in advanced zone.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Copy Markdown

utchoang commented Mar 29, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 29, 2022

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 29, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6177 (SL-JID-1313)

@Pearl1594
Copy link
Copy Markdown
Contributor

Pearl1594 commented Mar 29, 2022

@weizhouapache would it be better to call this.initAddIpRangeForm() in created() to maintain consistency with other forms?

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Mar 29, 2022

@weizhouapache would it be better to call this.initAddIpRangeForm() in created() to maintain consistency with other forms?

@Pearl1594
it looks not needed. the two forms use different variables.

    initAddIpRangeForm () {
      this.formRef = ref()
      this.form = reactive({})
      this.rules = reactive({
        podid: [{ required: true, message: this.$t('label.required') }],
        gateway: [{ required: true, message: this.$t('label.required') }],
        netmask: [{ required: true, message: this.$t('label.required') }],
        startip: [{ required: true, message: this.$t('label.required') }],
        endip: [{ required: true, message: this.$t('label.required') }]
      })
    },
    initFormUpdateRange () {
      this.updRangeRef = ref()
      this.formUpdRange = reactive({})
      this.updRangeRules = reactive({
        startip: [{ required: true, message: this.$t('label.required') }],
        endip: [{ required: true, message: this.$t('label.required') }],
        gateway: [{ required: true, message: this.$t('label.required') }],
        netmask: [{ required: true, message: this.$t('label.required') }]
      })
    },

Pearl1594
Pearl1594 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache weizhouapache merged commit d910c3c into apache:main Mar 29, 2022
@nvazquez nvazquez added this to the 4.17.0.0 milestone Mar 30, 2022
@weizhouapache weizhouapache deleted the 4.17-ui-fix-update-public-ip branch December 9, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

component:UI type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Todo

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @utchoang @blueorangutan @Pearl1594 @nvazquez