Skip to content

Set UefiCapabilty for all hypervisors in hostresponse#6140

Merged
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:add-uefi-response
Mar 21, 2022
Merged

Set UefiCapabilty for all hypervisors in hostresponse#6140
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:add-uefi-response

Conversation

@davidjumani
Copy link
Copy Markdown
Contributor

@davidjumani davidjumani commented Mar 18, 2022

Description

Sets the ueficapability flag for all hypervisor types, not just KVM

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

Before :

(localhost) 🐱 > list hosts filter=name,ueficapability,
{
  "count": 5,
  "host": [
    {
      "name": "s-2-VM"
    },
    {
      "name": "SimulatedAgent.92502eaf-4bd2-4f79-a16b-ef71b7283a51"
    },
    {
      "name": "SimulatedAgent.ce1e03f7-7240-4655-9a7a-6fa81286c289"
    },
    {
      "name": "SimulatedAgent.225c478e-9777-450f-ac80-c4657b0beeb3"
    },
    {
      "name": "SimulatedAgent.9c33d117-7fef-46aa-a806-0ff58a81d7c7"
    }
  ]
}

After :

(localhost) 🐱 > list hosts filter=name,ueficapability,
{
  "count": 5,
  "host": [
    {
      "name": "s-2-VM"
    },
    {
      "name": "SimulatedAgent.92502eaf-4bd2-4f79-a16b-ef71b7283a51",
      "ueficapability": false
    },
    {
      "name": "SimulatedAgent.ce1e03f7-7240-4655-9a7a-6fa81286c289",
      "ueficapability": false
    },
    {
      "name": "SimulatedAgent.225c478e-9777-450f-ac80-c4657b0beeb3",
      "ueficapability": true
    },
    {
      "name": "SimulatedAgent.9c33d117-7fef-46aa-a806-0ff58a81d7c7",
      "ueficapability": true
    }
  ]
}

@davidjumani
Copy link
Copy Markdown
Contributor Author

davidjumani commented Mar 18, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2022

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@davidjumani davidjumani added this to the 4.17.0.0 milestone Mar 18, 2022
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2929

@davidjumani
Copy link
Copy Markdown
Contributor Author

davidjumani commented Mar 18, 2022

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2022

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache
weizhouapache approved these changes Mar 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2022

Trillian test result (tid-3663)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31503 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6140-t3663-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Mar 21, 2022

shouldn't this be usinfied with #6139 , @davidjumani ?

nvazquez
nvazquez approved these changes Mar 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit 6125886 into apache:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:api

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@davidjumani @blueorangutan @DaanHoogland @nvazquez @weizhouapache