Skip to content

ui: Support to specify security groups when updating/editing a VM (adv zone + SG)#6138

Merged
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:add-security-groups
Mar 21, 2022
Merged

ui: Support to specify security groups when updating/editing a VM (adv zone + SG)#6138
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:add-security-groups

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Mar 18, 2022

Description

This PR provides a means of updating a stopped VM with security groups.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

Advanced Zone with Security Groups:

  • Provision to select multiple security groups:
    multi-select-sg
  • Displays the security groups associated with the VM as a space separated list in the Details tab of the VM:
    image
  • Ensured that the fields do not appear in the Advanced zone Tabs

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Mar 18, 2022

@Pearl1594
does the issue exist in 4.16 as well ?

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 18, 2022 •
edited
Loading

Yes it does @weizhouapache , but since it isn't a bug I targeted it for 4.17 - should we move it to 4.16??

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Mar 18, 2022

Yes it does @weizhouapache , but since it isn't a bug I targeted it for 4.17 - should we move it to 4.16??

@Pearl1594
OK, then no need to move to 4.16

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 18, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2022

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6138 (SL-JID-1271)

@nvazquez nvazquez added this to the 4.17.0.0 milestone Mar 21, 2022
utchoang
utchoang reviewed Mar 21, 2022
View reviewed changes
Comment thread ui/src/components/view/DetailsTab.vue Outdated
utchoang
utchoang reviewed Mar 21, 2022
View reviewed changes
Comment thread ui/src/components/view/DetailsTab.vue Outdated
@utchoang
Copy link
Copy Markdown

utchoang commented Mar 21, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 21, 2022

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 21, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6138 (SL-JID-1278)

utchoang
utchoang approved these changes Mar 21, 2022
View reviewed changes
Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

weizhouapache
weizhouapache approved these changes Mar 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@nvazquez nvazquez merged commit 38a0ded into apache:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@utchoang utchoang utchoang approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees

No one assigned

Labels

component:UI type:enhancement

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Pearl1594 @weizhouapache @blueorangutan @utchoang @nvazquez