Skip to content

account check made explicit - cleanup#6122

Merged
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:inviteUpdateCleanup
Mar 21, 2022
Merged

account check made explicit - cleanup#6122
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:inviteUpdateCleanup

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Mar 15, 2022

Description

This PR cleans up and restructures the code that checks and applies invites on update.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

should be tested by the project smoke tests.

@DaanHoogland DaanHoogland added this to the 4.17.0.0 milestone Mar 15, 2022
@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Mar 15, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 15, 2022

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 15, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2887

@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Mar 15, 2022

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 15, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 15, 2022

Trillian test result (tid-3617)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31379 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6122-t3617-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

nvazquez
nvazquez approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

yadvr
yadvr approved these changes Mar 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add unit test (optionally also a marvin test case if it doesn't already exist) for this change?

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Mar 17, 2022

LGTM, can you add unit test (optionally also a marvin test case if it doesn't already exist) for this change?

As stated in the description @rohityadavcloud "should be tested by the project smoke tests."

Pearl1594
Pearl1594 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@nvazquez nvazquez merged commit 3e4e417 into apache:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

Severity:Minor type:cleanup

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland @blueorangutan @nvazquez @yadvr @Pearl1594