CLOUDSTACK-8655: [Browser Based Upload Volume] Partially uploaded vol…#611
Closed
koushik-das wants to merge 1 commit into
Closed
CLOUDSTACK-8655: [Browser Based Upload Volume] Partially uploaded vol…#611koushik-das wants to merge 1 commit into
koushik-das wants to merge 1 commit into
Conversation
…umes are not getting destroyed as part of storage GC As part of volume sync, that runs during of SSVM start-up, the volume_store_ref entry was getting deleted. Volume GC relies on this entry to move volume to destroyed state. Since the entry was getting deleted, GC thread never moved the volume from UploadError/UploadAbandoned to Destroyed. Fix is to not remove the volume_store_ref entry as part of volume sync and let GC thread handle the clean up.
Contributor
Author
|
Test browser based incomplete volume upload, followed by SSVM destroy. Volume should go to UploadAbandoned/Error state and get cleaned up. ... === TestName: test_browser_upload_volume_incomplete | Status : SUCCESS === Ran 1 test in 351.347s OK |
|
cloudstack-pull-rats #92 SUCCESS |
|
cloudstack-pull-requests #790 SUCCESS |
|
cloudstack-pull-analysis #25 SUCCESS |
Member
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
maneesha-p
pushed a commit
to maneesha-p/cloudstack
that referenced
this pull request
Jul 31, 2015
…umes are not getting destroyed as part of storage GC As part of volume sync, that runs during of SSVM start-up, the volume_store_ref entry was getting deleted. Volume GC relies on this entry to move volume to destroyed state. Since the entry was getting deleted, GC thread never moved the volume from UploadError/UploadAbandoned to Destroyed. Fix is to not remove the volume_store_ref entry as part of volume sync and let GC thread handle the clean up. This closes apache#611
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
* Add contextual info to forms * additional tooltips - Primary storage form Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…umes are not getting destroyed as part of storage GC
As part of volume sync, that runs during of SSVM start-up, the volume_store_ref entry was getting deleted. Volume GC relies on this entry to move volume to destroyed state.
Since the entry was getting deleted, GC thread never moved the volume from UploadError/UploadAbandoned to Destroyed. Fix is to not remove the volume_store_ref entry as part
of volume sync and let GC thread handle the clean up.