coverity issues in old upgrade code#603
Merged
Merged
Conversation
|
cloudstack-pull-rats #85 SUCCESS |
|
cloudstack-pull-requests #783 SUCCESS |
|
cloudstack-pull-analysis #18 SUCCESS |
fef3093 to
53535d6
Compare
|
cloudstack-pull-rats #176 FAILURE |
|
cloudstack-pull-requests #874 ABORTED |
|
cloudstack-pull-analysis #109 ABORTED |
Contributor
|
Went through the file, had just one remark which won't cause trouble. I would rather remove the old code other them keeping it commented out. But that's just an upgrade file. :) it LGTM 👍 |
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Aug 3, 2015
* pr/603: coverity: try-with-resource and restructure in upgrade datacenter extra try-w-r coverity issues in old upgrade code Signed-off-by: Daan Hoogland <daan@onecht.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a lot of issues in this file so doing some iterations on it.
some unused, lot of resource leakage.