Skip to content

Coverity issues in OmniwireClassRegistry#600

Closed
DaanHoogland wants to merge 2 commits into
apache:masterfrom
DaanHoogland:coverity-omniwire
Closed

Coverity issues in OmniwireClassRegistry#600
DaanHoogland wants to merge 2 commits into
apache:masterfrom
DaanHoogland:coverity-omniwire

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Jul 16, 2015

No description provided.

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 16, 2015

cloudstack-pull-rats #70 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 16, 2015

cloudstack-pull-requests #767 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 16, 2015

cloudstack-pull-analysis #3 ABORTED

@wilderrodrigues
Copy link
Copy Markdown
Contributor

wilderrodrigues commented Jul 16, 2015

LGTM 👍

koushik-das
koushik-das reviewed Jul 17, 2015
View reviewed changes
Comment thread framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java Outdated
Copy link
Copy Markdown
Contributor

@koushik-das koushik-das Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a filePath != null immediately below. The check can go inside that to avoid duplication.

Copy link
Copy Markdown
Contributor Author

@DaanHoogland DaanHoogland Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do that as there is a new assignment to the var in the if block. The replaceAll contract doesn't state a null retrun as possibiliy so I'll move the replaceAll inside the next if block if the rest of the flow allows it

@DaanHoogland
coverity 1116759: possible null-pointer before indexOf-call
a52b2b5 
 move the if-block inside the next, guarded one
@asfbot
Copy link
Copy Markdown

asfbot commented Jul 17, 2015

cloudstack-pull-rats #74 SUCCESS
This pull request looks good

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 17, 2015

cloudstack-pull-requests #772 SUCCESS
This pull request looks good

@koushik-das
Copy link
Copy Markdown
Contributor

koushik-das commented Jul 17, 2015

LGTM

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 17, 2015

cloudstack-pull-analysis #7 SUCCESS
This pull request looks good

@wido
Copy link
Copy Markdown
Contributor

wido commented Jul 17, 2015

@DaanHoogland You can merge it I think

@asfgit asfgit closed this in f15eaec Jul 17, 2015
maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Jul 31, 2015
@DaanHoogland
coverity 1116759: possible null-pointer before indexOf-call move the …
b01ac7b 
…if-block inside the next, guarded one

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes apache#600
@DaanHoogland DaanHoogland deleted the coverity-omniwire branch August 11, 2015 22:29
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@yadvr
VM Wizard: Custom RAM field compute offering (#600)
10beb40 
* Custom RAM input field compute offering

* add a new translation for memory (MB) key

* remove unnecessary formatting

* Reuse the slider.

* remove `MB` from behind memory input

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
JoaoJandre pushed a commit to scclouds/cloudstack that referenced this pull request Nov 24, 2022
Merge branch 'fix_issue_600' into '4.16.0.0-scclouds'
94b698d 
Refatoração da validação de UUID realizada pelo CloudStack internamente

Closes apache#600

See merge request scclouds/scclouds!320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland @asfbot @wilderrodrigues @koushik-das @wido