Skip to content

CLOUDSTACK-8642: SSO Method not allowed bug fix.#598

Closed
borisroman wants to merge 1 commit into
apache:masterfrom
borisroman:CLOUDSTACK-8642
Closed

CLOUDSTACK-8642: SSO Method not allowed bug fix.#598
borisroman wants to merge 1 commit into
apache:masterfrom
borisroman:CLOUDSTACK-8642

Conversation

@borisroman
Copy link
Copy Markdown
Contributor

Due to CLOUDSTACK-8505 and commit 1c81b24 only POST methods are allowed. This needs to be explicitly stated in the AJAX method.

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 16, 2015

cloudstack-pull-rats #67 SUCCESS
This pull request looks good

@wido
Copy link
Copy Markdown
Contributor

wido commented Jul 16, 2015

LGTM

Seems like a use-case which was missed when this was changed

@asfbot
Copy link
Copy Markdown

asfbot commented Jul 16, 2015

cloudstack-pull-requests #764 SUCCESS
This pull request looks good

@DaanHoogland
Copy link
Copy Markdown
Contributor

makes sense, do we have a unit test mech on javascript code?

LGTM

@wilderrodrigues
Copy link
Copy Markdown
Contributor

LGTM.

who will merge it? :)

@DaanHoogland
Copy link
Copy Markdown
Contributor

I should, mine was the second 'LGTM' but was hoping for some discussion on javascript test code

@asfgit asfgit closed this in b1e5906 Jul 16, 2015
asfgit pushed a commit that referenced this pull request Jul 16, 2015
…05 and commit 1c81b24

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #598

(cherry picked from commit b1e5906)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Jul 31, 2015
…05 and commit 1c81b24

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes apache#598
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request Aug 3, 2015
…05 and commit 1c81b24

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes apache#598

(cherry picked from commit b1e5906)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 56522fd)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request Aug 5, 2015
…05 and commit 1c81b24

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes apache#598

(cherry picked from commit b1e5906)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 56522fd)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request Oct 30, 2015
…05 and commit 1c81b24

Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes apache#598

(cherry picked from commit b1e5906)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 56522fd)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
* Fix page navigation error when delete template.

* removed double `!` syntax

Fixes #598

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants