CLOUDSTACK-8580: user can view, expunge and restore VMs#593
Conversation
… vm's themselves. Two configuration options are added to allow this behaviour on a global or per account scale. Configuration options default to false.
|
cloudstack-pull-rats #57 SUCCESS |
|
cloudstack-pull-requests #754 SUCCESS |
|
Can you add the description of the functionality is short to the pr title? for instance 'CLOUDSTACK-8580: user access to deleted VMs' |
|
Added description to title. |
|
cloudstack-pull-rats #60 ABORTED |
|
cloudstack-pull-rats #61 ABORTED |
|
cloudstack-pull-requests #757 SUCCESS |
|
cloudstack-pull-requests #758 UNSTABLE |
|
LGTM 👍 |
|
no comments on the code but can you describe and add tests? |
|
LGTM A test would be welcome indeed |
|
LGTM. |
|
Since this one got 3 LGTM's but there are outstanding test requests, how to proceed? Do I merge it or wait for the tests? |
|
Wido, I want tests but if three other people want to merge it I'm not going to stand between them and the repo on my own. (btw I shouldn't have to) |
|
@wido same as @DaanHoogland here, ideal case we would have marvin tests…but... |
|
@wido @DaanHoogland @borisroman @Runseb I will test it manually before proceeding with a merge. I will also add an integration test for that and send in a new PR. Cheers, |
|
Perhaps a bit more of detail on the PR description, like test steps. I had to look at the diff of the code in order to find the new configuration key. Due to that, will have to restart the tests - had create account / VM and destroyed VM. :( No worries, just a hint. ;) Cheers, |
|
Hi guys, I tested the PR and it works fine. Below the steps I followed:
Was not able to see any option to restore the VM. Is it suppose to work only via cloudmonkey? Check the image bellow.
And the global settings:
|
|
Okay, guys... never mind. I see now that I have to set 2 new values, not just one. |
|
Creating 2 VMs via cloudmonkey (local) 🐵 > deploy virtualmachine displayname=isovm networkids=61fb9ffe-cf5e-4a09-9470-e0800685f74d templateid=2853716f-311a-11e5-b59a-5254001daa61 zoneid=38d556a7-39e5-4b70-9ce2-9bed1a16abc5 serviceofferingid=5ffbfb25-7df3-4b00-b053-cda67b5b46a9 (local) 🐵 > deploy virtualmachine displayname=isovm2 networkids=61fb9ffe-cf5e-4a09-9470-e0800685f74d templateid=2853716f-311a-11e5-b59a-5254001daa61 zoneid=38d556a7-39e5-4b70-9ce2-9bed1a16abc5 serviceofferingid=5ffbfb25-7df3-4b00-b053-cda67b5b46a9 Destroying 1 VM via cloudmonkey (no expunge) (local) 🐵 > destroy virtualmachine id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4 Recovering 1 VM via cloudmonkey (local) 🐵 > recover virtualmachine id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4 Starting 1 VM via cloudmonkey (local) 🐵 > start virtualmachine id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4
Destroying 1 VM via cloudmonkey (expunge) (local) 🐵 > destroy virtualmachine id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4 expunge=true
All L-super-GTM 👍 Merging... :) |
… vm's themselves. Two configuration options are added to allow this behaviour on a global or per account scale. Configuration options default to false. Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com> This closes apache#593
* Improve vApps properties section adding categories and sort order * fix vapps property with select error Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Users are now able to view, expunge and recover their vm's themselves. Two configuration options are added to allow this behaviour on a global or per account scale. Configuration options default to false.