Skip to content

CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with disksize parameter#592

Closed
pritisarap12 wants to merge 2 commits into
apache:masterfrom
pritisarap12:CLOUDSTACK-8636-Verify-failure-of-creation-of-Custom-disk-offering-with-disksize-parameter
Closed

CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with disksize parameter#592
pritisarap12 wants to merge 2 commits into
apache:masterfrom
pritisarap12:CLOUDSTACK-8636-Verify-failure-of-creation-of-Custom-disk-offering-with-disksize-parameter

Conversation

@pritisarap12

Copy link
Copy Markdown

Custom disk creation should not take disksize parameter while creating the disk offering

@wilderrodrigues

Copy link
Copy Markdown
Contributor

This description looks better, @pritisarap12 . I think you meant something like that for your previous PR.

I will wait for the build/travis and vote on them.

Cheers,
Wilder

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to product bug, if custom disk offering is created with size we need to delete it as part of cleanup. Can you please handle this?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the testcase as per review changes.

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #53 SUCCESS
This pull request looks good

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #750 SUCCESS
This pull request looks good

…th disksize parameter

	--Clear disk offering in tearDown() class if gets created
@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #55 SUCCESS
This pull request looks good

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

Sanjeev N on dev@cloudstack.apache.org replies:
LGTM

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #752 SUCCESS
This pull request looks good

@yadvr

yadvr commented Jul 15, 2015

Copy link
Copy Markdown
Member

LGTM

@asfgit asfgit closed this in 373b107 Jul 15, 2015
@yadvr

yadvr commented Jul 15, 2015

Copy link
Copy Markdown
Member

squashed/merged your commits; in future please try to squash them as you iterate with your reviews

maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Jul 31, 2015
…ith disksize parameter

- Clear disk offering in tearDown() class if gets created

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes apache#592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants