Skip to content

CLOUDSTACK-8632: Unable to revert snapshot on XenServer#590

Closed
pritisarap12 wants to merge 3 commits into
apache:masterfrom
pritisarap12:CLOUDSTACK-8632-Unable-to-revert-snapshot-on-XenServer
Closed

CLOUDSTACK-8632: Unable to revert snapshot on XenServer#590
pritisarap12 wants to merge 3 commits into
apache:masterfrom
pritisarap12:CLOUDSTACK-8632-Unable-to-revert-snapshot-on-XenServer

Conversation

@pritisarap12

@pritisarap12 pritisarap12 commented Jul 15, 2015

Copy link
Copy Markdown

On XenServer check that volume snapshot fails for the ROOT volume of VM which has VM snapshot created.

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #50 SUCCESS
This pull request looks good

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #747 UNSTABLE
Looks like there's a problem with this pull request

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #51 SUCCESS
This pull request looks good

@wilderrodrigues

wilderrodrigues commented Jul 15, 2015

Copy link
Copy Markdown
Contributor

Hi @pritisarap12

The issue/PR title says "Unable to rever snapshot on XenServer", however you have created a component test to "check that volume snapshot fails for the ROOT volume of VM which has VM snapshot created."

Could you please just elaborate a bit more on the meaning of this PR?

Cheers,
Wilder

sanju1010
sanju1010 reviewed Jul 15, 2015
View reviewed changes
Comment thread test/integration/testpaths/testpath_revert_snap.py Outdated

@sanju1010 sanju1010 Jul 15, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, compare whether the list is returning PASS or not.

@pritisarap12 pritisarap12 Jul 15, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated testcase with review changes.

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #748 UNSTABLE
Looks like there's a problem with this pull request

CLOUDSTACK-8636: Verify failure of creation of Custom disk offering w…
e07719d 
…ith disksize parameter

	-Modified list validation of volume list
@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #56 SUCCESS
This pull request looks good

@asfbot

asfbot commented Jul 15, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #753 UNSTABLE
Looks like there's a problem with this pull request

@wilderrodrigues

wilderrodrigues commented Jul 16, 2015

Copy link
Copy Markdown
Contributor

LGTM

@asfgit asfgit closed this in faaf6b1 Jul 20, 2015
maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Jul 31, 2015
CLOUDSTACK-8636: Verify failure of creation of Custom disk offering w…
ae2da3e 
…ith disksize parameter -Modified list validation of volume list

This closes apache#590
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
src: assorted bug fixes (#594)
58dddc2 
Fixes:
#588
#589
#590
#591
#601
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pritisarap12 @asfbot @wilderrodrigues @sanju1010