UI - Fix Locked "Override Root Disk Size" switch#5843
Merged
sureshanaparti merged 2 commits intoJan 10, 2022
Merged
Conversation
Author
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✖️ |
Contributor
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✖️ |
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
GabrielBrascher
approved these changes
Jan 10, 2022
GabrielBrascher
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @utchoang!
LGTM, based on manual tests and code review.
sureshanaparti
approved these changes
Jan 10, 2022
sureshanaparti
left a comment
Contributor
There was a problem hiding this comment.
Verified 'Override Root Disk Size' toggle in New instance wizard, with different compute offerings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5842
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Fixes error found when entering the "Add Instances" page
Fixes root disk size switch being locked when changing offerings
How Has This Been Tested?