CLOUDSTACK-8630: Fix for missing Firewall service parameter in test script#581
Closed
pavanb018 wants to merge 2 commits into
Closed
CLOUDSTACK-8630: Fix for missing Firewall service parameter in test script#581pavanb018 wants to merge 2 commits into
pavanb018 wants to merge 2 commits into
Conversation
|
cloudstack-pull-rats #39 ABORTED |
|
cloudstack-pull-requests #735 SUCCESS |
|
Sanjeev N on dev@cloudstack.apache.org replies: |
Contributor
|
👎 What does a "Newb" as the PR title means? We are trying to organise the way we work and avoid such PR titles. Please create an issue on Jira (https://issues.apache.org/jira/browse/CLOUDSTACK) and use the issue title as the PR title. Cheers, |
Contributor
Author
|
Created an ACS ticket describing the changes. |
Contributor
|
Thanks for the quick fix, @pavanb018 Now it LGTM 👍 Please proceed with the merge. |
Contributor
|
Committed to ACS master: |
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Create/Delete a LB rule and verify correct usage is recorded ... === TestName: test_01_lb_usage | Status : SUCCESS ===
ok
Ran 1 test in 50.564s
OK