CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its… - #571
Closed
koushik-das wants to merge 2 commits into
Closed
CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its…#571koushik-das wants to merge 2 commits into
koushik-das wants to merge 2 commits into
Conversation
… initial start-up process If SSVM cannot be started then the existing entry is removed and a new SSVM gets created. Made similar changes for CPVM as well. Also cleaned up some log messages in SSVM and CPVM manager code.
|
cloudstack-pull-rats #25 SUCCESS |
|
cloudstack-pull-requests #720 SUCCESS |
Contributor
|
LGTM. |
Member
|
Can you add some unit tests or marvin tests? |
Member
|
LGTM. |
Contributor
|
I would like to see tests with such a change as well |
… initial start-up process Added unit tests
Contributor
Author
|
@karuturi @DaanHoogland Added unit tests for CPVM allocation. |
|
cloudstack-pull-rats #37 ABORTED |
Contributor
|
test logic makes sense; LGTM waiting for travis |
|
cloudstack-pull-requests #733 UNSTABLE |
Contributor
Author
|
Although RAT build status is showing ABORTED, the report is clean. Also the build failed due to some random test failure. Since travis is green, I am going ahead with the merge. |
yadvr
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Jul 14, 2015
… initial start-up process Added unit tests This closes apache#571
Contributor
Author
|
Manually closing PR. I did a rebase to do away with unnecessary merge commit. |
maneesha-p
pushed a commit
to maneesha-p/cloudstack
that referenced
this pull request
Jul 31, 2015
… initial start-up process Added unit tests This closes apache#571
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… initial start-up process
If SSVM cannot be started then the existing entry is removed and a new SSVM gets created. Made similar changes for CPVM as well.
Also cleaned up some log messages in SSVM and CPVM manager code.